Closed
Conversation
keep PMT waveforms in stage and add fcl to drop them later
…T-metadata Enable Metadata Injection for Production
…r_SBN2025A Add Geant4Reweight configs
CRT Hit Truth Label Override
Update standard overlay+data reco fcl files to 2D SP.
This PR re-introduces CRTData in Stage0.
…r were left uninitialized.
…d added TriggerTimestamp variable to DAQTree.
Member
Author
|
For reference: these new tags are now available in |
…s overriden for Run 4.
…Analysis Fix issue where CRT HitTree in calibration tuples did not store run number.
…l-tags Update TPC calibration to tag including 2D-based Run2+4 calibrations.
Add in option to control YZMap+Electron lifetime DB from fcl.
Contributor
|
@jedori0228 and @mvicenzi I'm only tagging y'all since Tracy is a reviewer for many other open PRs. Do either of you know of another reviewer I could request in addition to Jaesung? This seems like a lot to review for one person. It looks like this PR will need special attention since there are merge conflicts given recent upgrades to LArSoft. Note that even further updates may be needed after all of the work from release/SBN2025A is migrated over to develop. |
Member
Author
Contributor
|
Sounds good! I'm also the person migrating the work on release/SBN2025A over to develop. I'll make sure these changes make it in. I'll close this PR then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the tags for the PMT calibration databases to
PMT_CalibrationTags_Oct2025.Changes:
It requires an updated
pmt_cosmics_timing_data.dbinicarus_datawith thev2r3tag.