Extra SBND CRT Branches by henrylay97 · Pull Request #186 · SBNSoftware/sbnanaobj

henrylay97 · 2026-02-19T14:15:26Z

Quick checklist

Have you run git fetch and pulled the latest changes from the branch you're basing your PR against?
If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
Have you added a checksum in classes_def.xml to any and all new classes you're implementing, and rebuilt?
If you're updating classes, have you incremented the ClassVersion by one compared to develop in classes_def.xml?

Description

I am starting to put together slides and PRs to preserve work of mine that lives offline before I leave.

The SBND CRT information in the CAFs is missing a few little pieces that are useful to analyzers (and simple to add as they are already present in the reconstruction objects).

The tagger variable (which wall) for the CRTSpacePoints
The number of contributing hits variable for the CRTSpacePoints
The vector of taggers variable (which walls) for the CRTTrack
Boolean fields to quickly establish whether or not a CRT-TPC match is present.

This PR adds those branches to the StandardRecord structure.

Accompanying PR: SBNSoftware/sbncode#632
It is documented in slides: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45715

Li-Jiaoyang97 · 2026-03-05T18:05:03Z

Hi Henry,

Everything looks clear and thanks for adding these infos for analysers! :))

kjplows · 2026-03-12T12:55:26Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode#632 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03

FNALbuild · 2026-03-12T13:37:56Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-03-12T13:40:43Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-03-12T13:44:49Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T13:45:11Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T13:51:52Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T13:54:11Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

kjplows · 2026-03-12T16:04:54Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02_01 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode#632 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_02

FNALbuild · 2026-03-12T16:52:24Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-03-12T16:56:25Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-03-12T17:06:42Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T17:08:35Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

PetrilloAtWork

I left a few non-blocking suggestions:

using the CAF standard caf::kUninitializedInt for initialisation
move new bools at the end (CF-152)

Also recommended general maintenance beyond this PR:

turning the comments on the data members into Doxygen format
removing the virtual empty destructors ([CF-151])

sbnanaobj/StandardRecord/SRCRTSpacePoint.cxx

PetrilloAtWork · 2026-03-12T16:30:26Z

sbnanaobj/StandardRecord/SRCRTSpacePoint.h

+      int        nhits;        // the number of strip hits contributing to the space point
+      int        tagger;       // the tagger the space point is on


It's not your responsibility, but it would be a service to us if you could turn all these comments (not only the two new lines from your PR) into Doxygen comments, e.g.

Suggested change

int nhits; // the number of strip hits contributing to the space point

int tagger; // the tagger the space point is on

int nhits; ///< The number of strip hits contributing to the space point.

int tagger; ///< The tagger the space point is on.

Or you can tell us "no, thank you".

No no it's a good shout. I don't have time to do a sweep of other classes I'm responsible for but I'll do these!

sbnanaobj/StandardRecord/SRCRTSpacePointMatch.h

PetrilloAtWork · 2026-03-12T16:34:13Z

sbnanaobj/StandardRecord/SRSBNDCRTTrack.h

-
-      // TODO: Find way of adding taggers field
-      //      std::set<SBNDCRTTagger_t> taggers;  // which taggers were used to create the track
+      std::vector<int>          taggers;  // the taggers that were used to create the track


If you have a reference at hand (DocDB or C++ class name) add it in the comment to help people interpret e.g. what tagger 1 means).

And blah blah Doxygen format blah.

PetrilloAtWork · 2026-03-12T16:36:36Z

sbnanaobj/StandardRecord/SRCRTSpacePoint.h

Could you please remove the offending line above ([CF-151])? not your responsibility, it just should have never been there.

PetrilloAtWork · 2026-03-12T16:37:38Z

sbnanaobj/StandardRecord/SRCRTSpacePointMatch.h

      SRCRTSpacePointMatch();
      virtual ~SRCRTSpacePointMatch() {}

+      bool            matched;    // whether or not a match was made


... and could you add Doxygen format...

PetrilloAtWork · 2026-03-12T16:38:34Z

sbnanaobj/StandardRecord/SRSBNDCRTTrack.h

PetrilloAtWork · 2026-03-12T16:39:33Z

sbnanaobj/StandardRecord/SRSBNDCRTTrackMatch.h

+      bool           matched; // whether or not a match was made
+      SRSBNDCRTTrack track;   // the track
+      float          score;   // assessment of quality of matching (depends on alg configuration)


Grumble Doxygen grumble ggro.

PetrilloAtWork · 2026-03-12T16:44:40Z

sbnanaobj/StandardRecord/SRCRTSpacePointMatch.h

      SRCRTSpacePointMatch();
      virtual ~SRCRTSpacePointMatch() {}

+      bool            matched;    // whether or not a match was made


I suggest this data member to be moved at the end for C++ memory layout reasons ([CF-152]). If adopted, the initialiser in the constructor will also need to be moved accordingly.

PetrilloAtWork · 2026-03-12T16:50:48Z

sbnanaobj/StandardRecord/SRCRTSpacePoint.cxx

    time(std::numeric_limits<float>::signaling_NaN()),
    time_err(std::numeric_limits<float>::signaling_NaN()),
-    complete(false)
+    complete(false),


I suggest the bool data members to be moved at the end for memory layout reasons ([https://sbnsoftware.github.io/sbn/codingconv/CodingConventionsExplained.html#CF152]). Not really important (but it might change checksum, in which case the transient one should be removed from classes_def.xml).

Even on my last day I am learning things from you Gianluca! 😅

FNALbuild · 2026-03-12T17:40:19Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-12T17:43:51Z

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

henrylay97

Thanks Gianluca, very useful comments as ever!

I have responded to all comments. The checksum did need updating following the re-ordering of member variables and removal of destructors. Obviously I've only retained the most recent.

henrylay97 · 2026-03-13T11:20:56Z

sbnanaobj/StandardRecord/SRCRTSpacePoint.cxx

    time(std::numeric_limits<float>::signaling_NaN()),
    time_err(std::numeric_limits<float>::signaling_NaN()),
-    complete(false)
+    complete(false),


Even on my last day I am learning things from you Gianluca! 😅

henrylay97 · 2026-03-13T11:21:54Z

sbnanaobj/StandardRecord/SRCRTSpacePoint.h

+      int        nhits;        // the number of strip hits contributing to the space point
+      int        tagger;       // the tagger the space point is on


No no it's a good shout. I don't have time to do a sweep of other classes I'm responsible for but I'll do these!

kjplows · 2026-03-13T11:57:37Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode#632 SBNSoftware/sbn*@SBN_SUITE_v10_15_00

FNALbuild · 2026-03-13T12:13:13Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-03-13T12:15:51Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-03-13T12:18:31Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-13T12:18:31Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-13T12:43:59Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-03-13T13:25:01Z

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

PetrilloAtWork

One optional change was missed, for what it's worth.

henrylay97 added 5 commits February 17, 2026 04:47

Add tagger and nhits fields to CRT space point representation

a00768e

Add tagger vector field to CRT track representation

1e57f4e

Update classes_def.xml

54c36d6

Add matched flags for SBND TPC-CRT matching

9a8c195

Update the classes_def

281f7ae

henrylay97 requested review from JosiePaton and PetrilloAtWork February 19, 2026 14:15

henrylay97 self-assigned this Feb 19, 2026

henrylay97 added the enhancement New feature or request label Feb 19, 2026

henrylay97 mentioned this pull request Feb 19, 2026

Extra SBND CRT Branches SBNSoftware/sbncode#632

Merged

6 tasks

kjplows added this to SBN software development Mar 5, 2026

kjplows moved this to Open pull requests in SBN software development Mar 5, 2026

kjplows requested review from Li-Jiaoyang97 and removed request for JosiePaton March 5, 2026 11:41

Li-Jiaoyang97 approved these changes Mar 5, 2026

View reviewed changes

kjplows moved this from Open pull requests to Urgent checks in SBN software development Mar 12, 2026

PetrilloAtWork reviewed Mar 12, 2026

View reviewed changes

henrylay97 and others added 7 commits March 13, 2026 11:01

Apply good suggestions from Gianluca

a276d60

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

Add required header

600c56e

Re-order members

d81394a

Doxygen-ify the comments and add docDB link

a7a32c5

Re-order variables

0a1c05a

Remove unnecessary functions

d024f25

Update checksums, only keeping most recent from this development

4875e26

henrylay97 commented Mar 13, 2026

View reviewed changes

kjplows moved this from Urgent checks to To merge in SBN software development Mar 13, 2026

PetrilloAtWork approved these changes Mar 13, 2026

View reviewed changes

hgreenlee merged commit 849ce09 into develop Mar 13, 2026
3 of 6 checks passed

github-project-automation bot moved this from To merge to Done in SBN software development Mar 13, 2026

kjplows moved this from Done to Recently done in SBN software development Mar 13, 2026

hgreenlee added this to PR archaeology Mar 16, 2026

github-project-automation bot moved this to Done in PR archaeology Mar 16, 2026

		int nhits; // the number of strip hits contributing to the space point
		int tagger; // the tagger the space point is on

Conversation

henrylay97 commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Quick checklist

Description

Uh oh!

Li-Jiaoyang97 commented Mar 5, 2026

Uh oh!

kjplows commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

kjplows commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

PetrilloAtWork left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

FNALbuild commented Mar 12, 2026

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjplows commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

Uh oh!

FNALbuild commented Mar 13, 2026

henrylay97 commented Feb 19, 2026 •

edited

Loading

PetrilloAtWork left a comment •

edited

Loading