Conversation
…ign2 merge da dev
evanugarte
reviewed
Jan 29, 2026
api/config/config.example.json
Outdated
| "LED_SIGN": { | ||
| "ENABLED": false | ||
| }, | ||
| "LEETCODE_URL": "NOT_SET", |
Collaborator
There was a problem hiding this comment.
would this change in development vs prod
if it wouldnt, can we just do an ENABLED true/false
| const AuditLog = require('../models/AuditLog.js'); | ||
| const membershipState = require('../../util/constants').MEMBERSHIP_STATE; | ||
|
|
||
| router.get('/getAllUsers', async (req, res) => { |
Collaborator
There was a problem hiding this comment.
make life simple
Suggested change
| router.get('/getAllUsers', async (req, res) => { | |
| router.get('/', async (req, res) => { |
Comment on lines
+42
to
+43
| { value: firstName, title: 'User\'s first name', }, | ||
| { value: lastName, title: 'User\'s last name', } |
Collaborator
There was a problem hiding this comment.
do we need first and last name? up to you
if we just do username does that hurt anything, would be simpler
Contributor
Author
There was a problem hiding this comment.
names = easy to tell who's who on frontend
like who gonna know who "doggymuncher" is if there's no names you get what i mean
Comment on lines
48
to
59
| const doesUserExist = await checkIfUserExists(leetcodeUsername, token); | ||
| if (doesUserExist.responseData) { | ||
| setIsError(true); | ||
| setMessage('This username is already registered, please try again'); | ||
| return; | ||
| } | ||
| const newUser = { | ||
| username: leetcodeUsername, | ||
| firstName, | ||
| lastName | ||
| }; | ||
| if (!await addUser(newUser, token)) { |
Collaborator
There was a problem hiding this comment.
isntead of a second endpoint you could have the create api check if they exist
the create api can return 409, and if the frontend gets 409 then we just say they already are registered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.