Fix #2514 - Multi-domain overlap when pre-aligned data skips grooming alignment#2515
Merged
akenmorris merged 1 commit intomasterfrom Mar 10, 2026
Merged
Fix #2514 - Multi-domain overlap when pre-aligned data skips grooming alignment#2515akenmorris merged 1 commit intomasterfrom
akenmorris merged 1 commit intomasterfrom
Conversation
… alignment When users pre-align multi-domain data outside ShapeWorks and skip grooming alignment and enabled procrustes translation/rotation, Procrustes centers each domain to the origin, causing them to overlap in analysis. Fix by computing mean groomed mesh centroids per domain and applying as offset during local alignment, only when grooming alignment was not performed. Also update documentation for multi-domain alignment options and MCA modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users pre-align multi-domain data outside ShapeWorks and skip grooming alignment and enabled procrustes translation/rotation, Procrustes centers each domain to the origin, causing them to overlap in analysis. Fix by computing mean groomed mesh centroids per domain and applying as offset during local alignment, only when grooming alignment was not performed.
Also update documentation for multi-domain alignment options and MCA modes.