Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the remaining-list window factory in the page-building layer so callers in the roll-call and lottery flows can reliably unpack its return value and initialize the page callback without hitting the reported TypeError.
Changes:
- Moves
get_page_callbackcreation back intocreate_remaining_list_window. - Restores
return window, get_page_callbackfrom the correct function. - Removes the unreachable callback/return block that had been left under
create_weight_formula_window.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SECRANDOM-AQ. The issue was that: create_remaining_list_window implicitly returns None, causing TypeError during unpacking in show_remaining_list.
_create_weight_calculation_rule_window函数中get_page_callback的创建和返回位置，确保其正确返回。This fix was generated by Seer in Sentry, triggered by wsxyt. 👁️ Run ID: 1244467
Not quite right? Click here to continue debugging with Seer.