Fix SyntaxError: invalid escape sequence exceptions
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were caused by not using raw strings in the grammar. I discovered this problem when running tests on a repository that uses `daidepp` with a more strict configuration.
The previous commit fixes the `DeprecationWarning`s that were being suppressed, so this is now safe to enable.
This enables more errors and warnings, which should prevent regressing on problems that have already been fixed. I tried to also add `-X warn_default_encoding`, but `regex` (required by `parsimonious`) fails with it enabled.
Collaborator
Author
|
The changes are pretty minimal, and CI passes, so I'm just going to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were caused by not using raw strings in the grammar. I discovered this problem when running tests on a repository that uses
daideppwith a more strict configuration.I also made some changes to the test configuration to prevent problems like these from happening again without being caught.