Fix Protocol E2E sync test timeouts#17
Merged
miccy merged 2 commits intosync/bun-migrationfrom Feb 3, 2026
Merged
Conversation
9 tasks
The "client and relay have all data" test was timing out with the default 5000ms timeout. This commit adds 15000ms timeouts to this test and other "many steps" tests in the E2E sync suite, following the pattern established in commit 0a8f3ea. Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add internal documentation for Bun and Biome migration
Fix Protocol E2E sync test timeouts
Feb 3, 2026
miccy
approved these changes
Feb 3, 2026
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failing on
test/local-first/Protocol.test.tswith test timeouts in E2E sync suite. The "client and relay have all data" test was timing out at the default 5000ms limit.Changes
{ timeout: 15000 }to four E2E sync tests that perform reconciliation with multiple async disposable runners:"client and relay have all data""client has all data - many steps""relay has all data - many steps""client and relay each have a random half of the data - many steps"The timeout increase follows the pattern from commit
0a8f3ea, which fixed a similar flaky test in the same suite. These tests invoke thereconcilefunction which creates disposable runners in a loop, causing them to exceed the default timeout after the structured concurrency migration.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.