Skip to content

Fix Protocol E2E sync test timeouts#17

Merged
miccy merged 2 commits intosync/bun-migrationfrom
copilot/sub-pr-5-another-one
Feb 3, 2026
Merged

Fix Protocol E2E sync test timeouts#17
miccy merged 2 commits intosync/bun-migrationfrom
copilot/sub-pr-5-another-one

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 3, 2026

CI failing on test/local-first/Protocol.test.ts with test timeouts in E2E sync suite. The "client and relay have all data" test was timing out at the default 5000ms limit.

Changes

  • Added { timeout: 15000 } to four E2E sync tests that perform reconciliation with multiple async disposable runners:
    • "client and relay have all data"
    • "client has all data - many steps"
    • "relay has all data - many steps"
    • "client and relay each have a random half of the data - many steps"

The timeout increase follows the pattern from commit 0a8f3ea, which fixed a similar flaky test in the same suite. These tests invoke the reconcile function which creates disposable runners in a loop, causing them to exceed the default timeout after the structured concurrency migration.

it("client and relay have all data", { timeout: 15000 }, async () => {
  await using run = testCreateRunner();
  const [clientStorage, relayStorage] = await createStorages();
  await run(clientStorage.writeMessages(testOwnerIdBytes, messages));
  await run(relayStorage.writeMessages(testOwnerIdBytes, messages));

  const syncSteps = await reconcile(clientStorage, relayStorage);
  // ...
});

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

The "client and relay have all data" test was timing out with the default 5000ms timeout. This commit adds 15000ms timeouts to this test and other "many steps" tests in the E2E sync suite, following the pattern established in commit 0a8f3ea.

Co-authored-by: miccy <9729864+miccy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add internal documentation for Bun and Biome migration Fix Protocol E2E sync test timeouts Feb 3, 2026
Copilot AI requested a review from miccy February 3, 2026 16:59
@miccy miccy marked this pull request as ready for review February 3, 2026 17:07
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 3, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@miccy miccy merged commit 7f0d812 into sync/bun-migration Feb 3, 2026
2 checks passed
@miccy miccy deleted the copilot/sub-pr-5-another-one branch February 10, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants