Skip to content

Fix Biome lint errors in web Task tests #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miccy merged 4 commits into from
Feb 3, 2026
Merged

Fix Biome lint errors in web Task tests #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68778e3
Initial plan
Copilot Feb 3, 2026
ca68e41
fix: Remove non-null assertions in web Task.test.ts to pass Biome lint
Copilot Feb 3, 2026
89cf71b
fix: Use node: protocol for fs import in relay app
Copilot Feb 3, 2026
0aca87c
fix: Add biome-ignore for intentional hook call in Vue useOwner
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/relay/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { mkdirSync } from "node:fs";
import { createConsole, createConsoleEntryFormatter } from "@evolu/common";
import { createRelayDeps, createRunner, startRelay } from "@evolu/nodejs";
import { mkdirSync } from "fs";

// Ensure the database is created in a predictable location for Docker.
mkdirSync("data", { recursive: true });
Expand Down
1 change: 1 addition & 0 deletions packages/vue/src/useOwner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@ export const useOwner = (owner: SyncOwner | null): void => {

if (owner == null) return;

// biome-ignore lint/correctness/useHookAtTopLevel: intentional
evolu.useOwner(owner);
};
10 changes: 6 additions & 4 deletions packages/web/test/Task.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ describe("createRunner", () => {
const console = testCreateConsole();
await using _run = createRunner({ console });

const handler = addedListeners.get("error")!;
handler(new ErrorEvent("error", { error: new Error("test error") }));
const handler = addedListeners.get("error");
expect(handler).toBeDefined();
handler?.(new ErrorEvent("error", { error: new Error("test error") }));

const entries = console.getEntriesSnapshot();
expect(entries).toHaveLength(1);
Expand All @@ -79,8 +80,9 @@ describe("createRunner", () => {
const console = testCreateConsole();
await using _run = createRunner({ console });

const handler = addedListeners.get("unhandledrejection")!;
handler(
const handler = addedListeners.get("unhandledrejection");
expect(handler).toBeDefined();
handler?.(
new PromiseRejectionEvent("unhandledrejection", {
promise: Promise.resolve(),
reason: new Error("test rejection"),
Expand Down