Skip to content

src/examples/sssd*conf: Enable the ifp service by default#8649

Open
arrowd wants to merge 1 commit intoSSSD:masterfrom
arrowd:example-configs
Open

src/examples/sssd*conf: Enable the ifp service by default#8649
arrowd wants to merge 1 commit intoSSSD:masterfrom
arrowd:example-configs

Conversation

@arrowd
Copy link
Copy Markdown
Contributor

@arrowd arrowd commented Apr 27, 2026

It is required for sssctl program to work and when ifp is not enabled, it fails with an obscure message

It is required for sssctl program to work and when ifp is not enabled, it
fails with an obscure message
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SSSD configuration examples in src/examples/sssd-example.conf and src/examples/sssd.conf by adding the ifp service to the list of enabled services. I have no feedback to provide as no issues were identified in these changes.

@alexey-tikhonov
Copy link
Copy Markdown
Member

On Linux systems 'ifp' is d-bus socket activated service.
Doesn't it work the same way on FreeBSD?

@arrowd
Copy link
Copy Markdown
Contributor Author

arrowd commented Apr 27, 2026

After spending some time debugging the sssctl failure it turned out that I hit the following block https://github.com/SSSD/sssd/blob/master/src/monitor/monitor.c#L242-L245

The ifp service does not end up in the list if it wasn't specified in the config, and after failing to register itself with monitor, it immediately exits.

@alexey-tikhonov
Copy link
Copy Markdown
Member

After spending some time debugging the sssctl failure it turned out that I hit the following block https://github.com/SSSD/sssd/blob/master/src/monitor/monitor.c#L242-L245

The ifp service does not end up in the list if it wasn't specified in the config, and after failing to register itself with monitor, it immediately exits.

But it starts at least?

I guess it exits because

#ifdef HAVE_SYSTEMD

not met and socket_activated_service_not_found() isn't executed...

That's a real place that needs fixing...

@arrowd
Copy link
Copy Markdown
Contributor Author

arrowd commented Apr 27, 2026

Yes, the dbus autoactivation mechanism works.

What would be the correct fix?

@alexey-tikhonov
Copy link
Copy Markdown
Member

alexey-tikhonov commented Apr 27, 2026

It depends.
Maybe 'monitor' should allow/expect that any service can be started via external means, doesn't matter if built with/without SYSTEMD support.
Maybe only for 'ifp'...

Currently 'sssd_ifp' can be started automatically as d-bus service, other responders - via systemd socket activation.
Does FreeBSD have anything like systemd socket activation?

@arrowd
Copy link
Copy Markdown
Contributor Author

arrowd commented Apr 27, 2026

Does FreeBSD have anything like systemd socket activation?

No, our rc.d system is pretty simple wrt that. For dbus services we resort on dbus autoactivation.

@alexey-tikhonov
Copy link
Copy Markdown
Member

Then maybe an exception for 'ifp' makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants