[autobackport: sssd-2-13] KRB5: read keytab copy in offline mode too#8687
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the privileged_krb5_setup function in src/providers/krb5/krb5_child.c to adjust how the offline status affects Kerberos setup. Specifically, it removes the offline check from the outer conditional block that manages keytab setup and instead applies a !offline check specifically to the k5c_setup_fast call. I have no feedback to provide.
sumit-bose
left a comment
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
backport matches the original patch, ACK.
bye,
Sumit
The process can transition from offline pre-auth to online auth within the same invocation. Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit b070171)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8671-to-sssd-2-13
branch
from
c12da3e to
3fa894d
Compare
4 participants
This is an automatic backport of PR#8671 KRB5: read keytab copy in offline mode too to branch sssd-2-13, created by @alexey-tikhonov.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
b070171 - KRB5: read keytab copy in offline mode too
Backported commits
Original Pull Request Body
The process can transition from offline pre-auth to online auth within the same invocation.