Fix #7 : Export to excel for selected TaggedValue #8
Conversation
| foreach (var taggedValueToExport in taggedValuesToExport) | ||
| { | ||
| this.ExportableValues[taggedValueToExport] = element.TaggedValues.TryGetValue(taggedValueToExport, out var existingValue) | ||
| ? string.Join("\n", existingValue.Select(x => x.Value)) |
There was a problem hiding this comment.
can this be instead of \n the `Environment.Newline?
There was a problem hiding this comment.
Changed and tested
| }); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add newline at the end of each file. We had this rule earlier and it got removed. There is good reason to make diffs more readible when using git and git extensions
There was a problem hiding this comment.
A new line is already present on each file, just the Tests.csproj one that missed it
lxatstariongroup
left a comment
lxatstariongroup
left a comment
There was a problem hiding this comment.
Very nice code again, Antoine!
EA-ModelKit/App.cs
Outdated
| private static Assembly CurrentDomainOnAssemblyResolve(object sender, ResolveEventArgs args) | ||
| { | ||
| var folderPath = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location); | ||
| var folderPath = Path.GetDirectoryName(typeof(App).Assembly.Location); |
There was a problem hiding this comment.
For performance, this result could be stored in a private static field. Not a reason to stop landing.
|
Prerequisites
Description
Fix #7