implement build-url and build-url-short#3
Open
norbertbuchmueller wants to merge 1 commit intoSWCE:masterfrom
Open
implement build-url and build-url-short#3norbertbuchmueller wants to merge 1 commit intoSWCE:masterfrom
build-url and build-url-short#3norbertbuchmueller wants to merge 1 commit intoSWCE:masterfrom
Conversation
Author
|
@regevbr what's your opinion of the proposed changes? |
Contributor
|
@norbertbuchmueller thanks for the contribution and Sorry for the delay, I don't mind adding those "variables" but please refactor the code so you won't have to hack the values into the environment - create a method to extract the env values for the existing variables and pass the values directly to the handle prop method, then in your props, just pass the values without calling the helper method. Also please make sure the tests pass after you make the changes. @ezraroi what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One often uses the metadata envvars to construct a URL to the Concourse build page. This PR makes it easier - by moving the logic of that into this resource.