fix(book): partial-read progress classification and seed chunk position encoding#327
Merged
fix(book): partial-read progress classification and seed chunk position encoding#327
Conversation
… position encoding
SolfE
changed the title
SolfE
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
책 진행도 분류 회귀와 k6 시드 데이터 인코딩 불일치를 함께 수정했습니다.
Problem
/books?progress=IN_PROGRESS에서 일부 읽은 책(챕터 미완료)이 제외되어NOT_STARTED로 보일 수 있었습니다.maxReadChunkNumber가 서비스 비교 로직에서 사용하는 인코딩 형식과 달라 진행도 비교가 깨질 수 있었습니다.Solution
maxReadChunkNumber를chapter-first인코딩 값으로 저장하도록 변경했습니다.Changes
BookRepositoryImpl:chapterProgresses.progressPercentage > 0 && isCompleted = false조건을 포함.BookRepositoryImplTest:k6/seed/content/book/seed-books-content.mongosh.js:maxReadChunkNumber시드 값을 인코딩 포맷으로 저장.encodeChapterFirstPosition헬퍼 추가.Example
Related Issues