Skip to content

Change version output for protectdisc iso scan #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnadareski merged 1 commit into from
Feb 11, 2026
Merged

Change version output for protectdisc iso scan #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions BinaryObjectScanner/Protection/ProtectDISC.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,14 @@ public class ProtectDISC : IDiskImageCheck<ISO9660>, IExecutableCheck<PortableEx
// 7.5.0.61324 and 9.0.1119. ProtectDiSC versioning is very confusing, so this is not the "actual" version
// number and should not be printed.
// Previous versions just have spaces here, so it doesn't need to be validated beyond that.
var abstractIdentifierString = pvd.AbstractFileIdentifier.ReadNullTerminatedAnsiString(ref offset);
// Some ProtectDiSC 6 discs also have version number, such as RID 114936 having 1.1.2286.18916, and
// 131176 having 1.1.2162.19023. The below check is commented out because there's likely something that
// can be done with it, it's just difficult to do anything while ProtectDiSC versioning is still unclear.
/*var abstractIdentifierString = pvd.AbstractFileIdentifier.ReadNullTerminatedAnsiString(ref offset);
if (abstractIdentifierString is null || abstractIdentifierString.Trim().Length == 0)
return "ProtectDiSC 6-7.x";
return "ProtectDiSC 6-7.x";*/

return "ProtectDiSC 7.x+";
return "ProtectDiSC 6+";
}

/// <inheritdoc/>
Expand Down