Fix tests for ruby 4+ by replacing set.rb with erb.rb in tests after Set moved to C#125
Merged
SamSaffron merged 1 commit intoSamSaffron:masterfrom Mar 22, 2026
Merged
Conversation
Ruby moved Set to a C-based implementation, so set.rb no longer exists as a stdlib file. This broke tests that expected to see set.rb in profiler output. - Changed longhorn test fixture to require 'erb' instead of 'set' - Added STDLIB_FILE constant in test_helper.rb so the stdlib filename is defined in one place, making future changes easier - Updated all test assertions to reference STDLIB_FILE
Owner
|
Oh thanks so much! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby moved Set to a C-based implementation, so set.rb no longer exists as a stdlib file. This broke tests that expected to see set.rb in profiler output.