Skip to content

feat: wrap seek bar tooltips with a box, similar to thumbnail#569

Open
Samillion wants to merge 12 commits intomainfrom
seek_tooltip_box
Open

feat: wrap seek bar tooltips with a box, similar to thumbnail#569
Samillion wants to merge 12 commits intomainfrom
seek_tooltip_box

Conversation

@Samillion
Copy link
Owner

@Samillion Samillion commented Mar 21, 2026

Fixes: #567

Changes:

  • Wrap time and chapter seek bar tooltips with a box, same as thumbnail.
  • Only draw tooltip box for seekbar
  • Scale with tooltip font size, not time stamp font size
  • Increase spacing between seek bar tooltips
  • Adjust tooltip opacity, corner radius and horizontal padding
  • Change default value of seek_hover_tooltip_h_offset to 5
  • Add tooltip_seek to osc_styles
image

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

Hmm, if you increase the UI scale above 1, then the tooltip background starts to increasingly run away off screen edge.
This is what 3 looks like.

image

@Samillion
Copy link
Owner Author

Is that an issue though? Genuinely asking. The text positioning is correct, right? At the far edge of the slider (last pos)

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

Is that an issue though? Genuinely asking. The text positioning is correct, right? At the far edge of the slider (last pos)

The text is correct.

Using local pad_h, pad_v = 0, 3 fixes that padding issue. Might be biased, but I would make it default to avoid potential issues lol.

@Samillion
Copy link
Owner Author

Using local pad_h, pad_v = 0, 3 fixes that padding issue. Might be biased, but I would make it default to avoid potential issues lol.

0 only when no thumbfast or for all scenarios?

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

With thumbfast you would run into the same issue. Unless you would rather add a user option.

@Samillion
Copy link
Owner Author

Would pad_h value of 2 work? I don't have videos with long chapters on hand at the moment.

What I mean is, does pad_h have to be 0? On reasonable scales.

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

Would pad_h value of 2 work?

Yeah, pad_h of 2 looks perfect up to scale values of around 1.4 on my video. At 1.5 scale it starts to clip the edge.
But that should be a good solution.

@Samillion
Copy link
Owner Author

Samillion commented Mar 21, 2026

Done. Lowered horizontal padding to 2 from 5.

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

Thank you. How can we run it borderless? Border outline is always enabled, right?

@Samillion
Copy link
Owner Author

Done.

image

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

That's awesome. Such an improvement over how it looked yesterday haha.

Btw, if you like the border, I'm not against having it available. I just wanted a way to disable lol. What you have now is good for sure tho.

@Samillion
Copy link
Owner Author

Samillion commented Mar 21, 2026

Btw, if you like the border, I'm not against having it available. I just wanted a way to disable lol. What you have now is good for sure tho.

I really like your idea of no border, makes it blend in, looks right.

I'll merge tomorrow ish to see if @Xurdejl has suggestions, since he suggested the tooltips to be wrapped like that.

I'll have to re-do a lot of preview images and video 😭 but I won't do it right away, because I saw a sneaky Xurdejl messing with purple variants for seekbar lol.

Edit:
Speaking of purple. I genuinely love the orange default colors. I have no idea why, but it looks nice and unique ish.

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

If you don't mind more suggestions, should tooltip match the osc color of #000000 ? If not at least be a bit darker so it's easier to read.

Right now it follows thumbnail_border_color but it may not be super obvious that it's tied to tooltip. Should it be renamed?

I genuinely love the orange default colors. I have no idea why, but it looks nice and unique ish.

Of course, orange is always sexy, but I'm very biased in that regard lol.

@Samillion
Copy link
Owner Author

Samillion commented Mar 21, 2026

If you don't mind more suggestions, should tooltip match the osc color of #000000 ? If not at least be a bit darker so it's easier to read.

Good idea. Done.

image

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

The radius is at 8 but what do you think about 12. More pill shaped like that.

@Samillion
Copy link
Owner Author

Sorry, before I address that, do we still need seek_hover_tooltip_h_offset option?

That was initially added to adjust height in case of overlap. With this, overlap is fine, right? In other words, should the option be removed?

@Keith94
Copy link
Contributor

Keith94 commented Mar 21, 2026

The only way it's gonna overlap now is if you push hover_button_size to some extreme value.

But hover size ≤ 115 is perfect for most cases anyway. Should be good to remove.

@Samillion Samillion changed the title feat: wrap seekbar tooltips with box same as thumbnail feat: wrap seek bar tooltips with a box, similar to thumbnail Mar 22, 2026
@Samillion
Copy link
Owner Author

The radius is at 8 but what do you think about 12. More pill shaped like that.

12 feels a bit too much, no? even the round corner ends with a pointy center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thicker border on tooltip

2 participants