Skip to content

Support d flag for regular expressions#1150

Closed
zherczeg wants to merge 1 commit intoSamsung:masterfrom
zherczeg:regexp_d
Closed

Support d flag for regular expressions#1150
zherczeg wants to merge 1 commit intoSamsung:masterfrom
zherczeg:regexp_d

Conversation

@zherczeg
Copy link
Copy Markdown
Contributor

No description provided.

@zherczeg zherczeg marked this pull request as ready for review September 15, 2022 10:43
@zherczeg zherczeg force-pushed the regexp_d branch 2 times, most recently from 48100fa to 573429a Compare September 15, 2022 12:18
Copy link
Copy Markdown
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksh8281
Copy link
Copy Markdown
Contributor

ksh8281 commented Sep 19, 2022

IMO we need to add d flag into RegExpOption in EscargotPublic.h

@zherczeg zherczeg force-pushed the regexp_d branch 3 times, most recently from 2e09e32 to d360f11 Compare September 20, 2022 10:26
Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@ksh8281
Copy link
Copy Markdown
Contributor

ksh8281 commented Apr 28, 2026

Due to other PRs, not only parsing the flag but also actual support is provided.

@ksh8281 ksh8281 closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants