A copy of #9 with some corrections and me being opinionated#17
Open
ayroblu wants to merge 18 commits intoSamyPesse:masterfrom
Open
A copy of #9 with some corrections and me being opinionated#17ayroblu wants to merge 18 commits intoSamyPesse:masterfrom
ayroblu wants to merge 18 commits intoSamyPesse:masterfrom
Conversation
scirpt -> script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to use this package, it looked a little out of date so I quickly did up a few changes to make it look better in my linter. Its a copy of some of pyramation's stuff, but fixed.
Added a linter, added a test (with the front page's example in it)
Don't merge this in this state obviously, but it if you ask nicely I can undo some of my changes to be similar to your style (I couldn't get prepublish working with git-urls). I use 2 spaces and no semi colons, that's why there's so many changes. Appreciate your package! I could not figure out how MathJax could work with React until this!
yarn lint yarn test