Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .fernignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CLAUDE.md
LICENSE
README.md
examples/
testapp/
src/SchematicHQ.Client.Test/Cache/
src/SchematicHQ.Client.Test/Datastream/
src/SchematicHQ.Client.Test/Integration/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,20 @@ public async Task PerformHealthCheck_WhenReplicatorReady_SetsHealthyToTrue()

var service = new ReplicatorHealthService(httpClient, "http://test/ready", logger);

// Act
service.Start();

// Wait for health check to complete
await Task.Delay(100);
try
{
// Act — drive the check synchronously instead of racing Start()'s background
// task. GetCacheVersionAsync awaits PerformHealthCheck directly.
await service.GetCacheVersionAsync();

// Assert
Assert.That(service.IsHealthy, Is.True);
Assert.That(service.CacheVersion, Is.EqualTo("test123"));
// Assert
Assert.That(service.IsHealthy, Is.True);
Assert.That(service.CacheVersion, Is.EqualTo("test123"));
}
finally
{
service.Dispose();
}
}

[Test]
Expand Down Expand Up @@ -96,15 +101,19 @@ public async Task PerformHealthCheck_WhenReplicatorNotReady_SetsHealthyToFalse()

var service = new ReplicatorHealthService(httpClient, "http://test/ready", logger);

// Act
service.Start();

// Wait for health check to complete
await Task.Delay(100);
try
{
// Act — drive the check synchronously instead of racing Start()'s background task.
await service.GetCacheVersionAsync();

// Assert
Assert.That(service.IsHealthy, Is.False);
Assert.That(service.CacheVersion, Is.EqualTo("test123")); // Should still parse cache version
// Assert
Assert.That(service.IsHealthy, Is.False);
Assert.That(service.CacheVersion, Is.EqualTo("test123")); // Should still parse cache version
}
finally
{
service.Dispose();
}
}

[Test]
Expand Down
4 changes: 3 additions & 1 deletion src/SchematicHQ.Client/RulesEngine/FlagCheck.cs
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,9 @@ public static async Task<CheckFlagResult> CheckFlag(
.ToList();

var ruleChecker = RuleCheckService.NewRuleCheckService();
foreach (var group in GroupRulesByPriority(flag.Rules.ToList(), companyRules, userRules))
// The wire format may send `"rules": null` for flags with no rules; treat that as empty.
var flagRules = flag.Rules?.ToList() ?? new List<RulesengineRule>();
foreach (var group in GroupRulesByPriority(flagRules, companyRules, userRules))
{
foreach (var rule in group)
{
Expand Down
Loading
Loading