Skip to content

refactor: smaller cleanup tasks for casl refactor#2759

Open
HayenNico wants to merge 1 commit into
masterfrom
refactor-casl-factory-cleanup
Open

refactor: smaller cleanup tasks for casl refactor#2759
HayenNico wants to merge 1 commit into
masterfrom
refactor-casl-factory-cleanup

Conversation

@HayenNico
Copy link
Copy Markdown
Member

@HayenNico HayenNico commented May 26, 2026

Description

A few smaller changes part of PR #2748. This branch will serve as a base for the individual collection refactors.

Fixes

  • Fix faulty dataset API v4 test 2500-0400 with illegal query filter for count endpoint

Changes:

  • Rename Action.accessAny to Action.AccessAny
  • Sort Subjects in casl-ability-factory.ts, add GenericHistory as a valid term
  • Sort CaslAbilityFactory.endpointAccessors

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

Summary by Sourcery

Align CASL action naming and subject configuration while cleaning up access control wiring and fixing a dataset count test filter.

Bug Fixes:

  • Correct the datasets v4 count test to use an empty filter when requesting the count endpoint.

Enhancements:

  • Rename the generic CASL access action to a consistently cased enum value and update all usage sites.
  • Include GenericHistory in CASL Subjects and sort both Subjects and endpoint accessor mappings for improved maintainability.

@HayenNico HayenNico requested a review from a team as a code owner May 26, 2026 15:50
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant