fix(Dataset): allow public dataset access in v4 findById endpoint for unauthenticated users#2764
Closed
abdimo101 wants to merge 1 commit into
Closed
fix(Dataset): allow public dataset access in v4 findById endpoint for unauthenticated users#2764abdimo101 wants to merge 1 commit into
abdimo101 wants to merge 1 commit into
Conversation
HayenNico
reviewed
May 28, 2026
Member
HayenNico
left a comment
There was a problem hiding this comment.
Hi @abdimo101,
the DatasetReadOnePublic action/permission is only granted to unauthenticated users, who are forbidden from using any endpoints in datasets.v4.controller.ts by design. An unauthenticated user should use the /api/v4/datasets/public endpoints defined in datasets-public.v4.controller.ts instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows unauthenticated users to access published datasets through the V4
findByIdendpoint. The@CheckPoliciesdecorator now checks for both DatasetRead and DatasetReadOnePublic permissions just like in the V3findById.Motivation
Fixes
Changes:
Tests included
Documentation
official documentation info
Summary by Sourcery
Bug Fixes: