Implement agent skills #1304
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "appHostPath": "..\\src\\BotSharp.AppHost\\BotSharp.AppHost.csproj" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| namespace BotSharp.Abstraction.Agents.Models; | ||
|
|
||
| public class AgentSkill | ||
| { | ||
| /// <summary> | ||
| /// Name of the Skill | ||
| /// </summary> | ||
| [JsonPropertyName("name")] | ||
| public required string Name { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Description of the Skill | ||
| /// </summary> | ||
| [JsonPropertyName("description")] | ||
| public required string Description { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,7 @@ public class AgentCreationModel | |
| public List<AgentKnowledgeBase> KnowledgeBases { get; set; } = new(); | ||
| public List<AgentRule> Rules { get; set; } = new(); | ||
| public AgentLlmConfig? LlmConfig { get; set; } | ||
| public List<AgentSkill> Skills { get; set; } | ||
|
|
||
|
Comment on lines
73
to
76
There was a problem hiding this comment.
|
||
| public Agent ToAgent() | ||
| { | ||
|
|
@@ -100,6 +101,7 @@ public Agent ToAgent() | |
| KnowledgeBases = KnowledgeBases, | ||
| Rules = Rules, | ||
| RoutingRules = RoutingRules?.Select(x => RoutingRuleUpdateModel.ToDomainElement(x))?.ToList() ?? [], | ||
| Skills = Skills ?? new List<AgentSkill>(), | ||
| }; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| using BotSharp.Abstraction.Agents; | ||
| using BotSharp.Abstraction.Functions; | ||
| using BotSharp.Abstraction.Settings; | ||
| using BotSharp.Plugin.AgentSkills.Functions; | ||
| using BotSharp.Plugin.AgentSkills.Services; | ||
| using BotSharp.Plugin.AgentSkills.Skills; | ||
| using Microsoft.Extensions.AI; | ||
| using Microsoft.Extensions.Configuration; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| namespace BotSharp.Plugin.AgentSkills; | ||
|
|
||
| /// <summary> | ||
| /// Agent Skills plugin for BotSharp. | ||
| /// Enables AI agents to leverage reusable skills following the Agent Skills specification (https://agentskills.io). | ||
| /// Implements requirements: FR-1.1, FR-3.1, FR-4.1 | ||
| /// </summary> | ||
| public class AgentSkillsPlugin : IBotSharpPlugin | ||
| { | ||
| public string Id => "a5b3e8c1-7d2f-4a9e-b6c4-8f5d1e2a3b4c"; | ||
| public string Name => "Agent Skills"; | ||
| public string Description => "Enables AI agents to leverage reusable skills following the Agent Skills specification (https://agentskills.io)."; | ||
| public string IconUrl => "https://raw.githubusercontent.com/SciSharp/BotSharp/master/docs/static/logos/BotSharp.png"; | ||
| public string[] AgentIds => []; | ||
|
|
||
| /// <summary> | ||
| /// Register dependency injection services. | ||
| /// Implements requirements: FR-1.1, FR-3.1, FR-4.1, FR-6.1, NFR-4.1 | ||
| /// </summary> | ||
| public void RegisterDI(IServiceCollection services, IConfiguration config) | ||
| { | ||
| // FR-6.1: Register AgentSkillsSettings configuration | ||
| // Use ISettingService to bind configuration from appsettings.json | ||
| services.AddScoped(provider => | ||
| { | ||
| var settingService = provider.GetRequiredService<ISettingService>(); | ||
| return settingService.Bind<AgentSkillsSettings>("AgentSkills"); | ||
| }); | ||
|
|
||
| // FR-1.1: Register AgentSkillsFactory as singleton | ||
| // Singleton pattern avoids creating multiple factory instances | ||
| services.AddSingleton<AgentSkillsFactory>(); | ||
|
|
||
| // FR-1.1, NFR-4.1: Register ISkillService and SkillService as scoped | ||
| services.AddScoped<ISkillService, SkillService>(); | ||
|
|
||
| services.AddScoped<IFunctionCallback, GetInstructionsFn>(); | ||
| services.AddScoped<IFunctionCallback, GetSkillBynameFn>(); | ||
| services.AddScoped<IFunctionCallback, GetSkillFileContentFn>(); | ||
|
|
||
| // FR-2.1: Register AgentSkillsInstructionHook for instruction injection | ||
| services.AddScoped<IAgentHook, AgentSkillsInstructionHook>(); | ||
|
|
||
| // FR-3.1: Register AgentSkillsFunctionHook for function registration | ||
| services.AddScoped<IAgentHook, AgentSkillsFunctionHook>(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(TargetFramework)</TargetFramework> | ||
| <Nullable>enable</Nullable> | ||
| <LangVersion>$(LangVersion)</LangVersion> | ||
| <VersionPrefix>$(BotSharpVersion)</VersionPrefix> | ||
| <GeneratePackageOnBuild>$(GeneratePackageOnBuild)</GeneratePackageOnBuild> | ||
| <GenerateDocumentationFile>$(GenerateDocumentationFile)</GenerateDocumentationFile> | ||
| <OutputPath>$(SolutionDir)packages</OutputPath> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Content Include="data\agents\471ca181-375f-b16f-7134-5f868ecd31c6\agent.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </Content> | ||
| <Content Include="data\agents\471ca181-375f-b16f-7134-5f868ecd31c6\instructions\instruction.liquid"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </Content> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="YamlDotNet" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\Infrastructure\BotSharp.Core\BotSharp.Core.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description says the change only adds
.aspire/settings.json, but this PR also introduces a large AgentSkills plugin implementation, new test projects/assets, and storage model changes. Update the PR description to accurately reflect the scope, or split into separate PRs to keep reviews manageable.