fix(payout_worker): fix archive path and error handling in cleanup_old_withdrawals (M6)#6307
Open
waefrebeorn wants to merge 35 commits into
Open
fix(payout_worker): fix archive path and error handling in cleanup_old_withdrawals (M6)#6307waefrebeorn wants to merge 35 commits into
waefrebeorn wants to merge 35 commits into
Conversation
Adds max_length parameter to _clean_string_field and caps all user input fields in POST route handlers: - /lock: sender_wallet(128), target_wallet(128), tx_hash(128), receipt_signature(256) - /confirm: proof_ref(256), notes(1024) - /release: release_tx(128), notes(1024) Prevents storage of arbitrarily large strings in bridge_ledger DB.
…s + Row M error handling + Row T test gaps + Row E infrastructure
…rawals (M6) M6 - MED: payout_worker.py: cleanup_old_withdrawals file descriptor leak on archive - Archive file now uses proper path (archives/ dir next to DB) instead of CWD-relative - Uses .jsonl extension for append-log format - f.flush() after each row ensures data is persisted before DB deletion - OSError catch on file write prevents data loss: aborts without deleting DB - Separate error handling for DB prune so inconsistency is logged but graceful - Explicit column selection instead of SELECT * for maintainability
github-actions
Bot
added
documentation
jaxint
approved these changes
May 25, 2026
Contributor
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Great work on this PR. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
M6 — MED: payout_worker.py: cleanup_old_withdrawals uses relative path, no atomicity
Bugs
archive_file = f"withdrawal_archive_{...}.json"writes to CWD instead of a stable location — disappears on daemon restart or cwd changeFix
self.db_path+archives/subdir (os.makedirs with exist_ok)Testing
RTC Wallet for bounty:
RTC17c0d21f04f6f65c1a85c0aeb5d4a305d57531096