Skip to content

fix(solana-sdk): make WRTC_MINT_DEVNET env-var configurable [F32]#6315

Open
waefrebeorn wants to merge 40 commits into
Scottcjn:mainfrom
waefrebeorn:fix-solana-sdk-todo-devnet
Open

fix(solana-sdk): make WRTC_MINT_DEVNET env-var configurable [F32]#6315
waefrebeorn wants to merge 40 commits into
Scottcjn:mainfrom
waefrebeorn:fix-solana-sdk-todo-devnet

Conversation

@waefrebeorn
Copy link
Copy Markdown

Summary

Replaces hardcoded WRTC_MINT_DEVNET = "TODO_DEPLOY_ON_DEVNET" with os.environ.get("WRTC_MINT_DEVNET", "TODO_DEPLOY_ON_DEVNET") so devnet deployments can configure the mint address without code changes.

RTC Wallet for bounty: RTC17c0d21f04f6f65c1a85c0aeb5d4a305d57531096

Adds max_length parameter to _clean_string_field and caps all user input
fields in POST route handlers:

- /lock: sender_wallet(128), target_wallet(128), tx_hash(128), receipt_signature(256)
- /confirm: proof_ref(256), notes(1024)
- /release: release_tx(128), notes(1024)

Prevents storage of arbitrarily large strings in bridge_ledger DB.
…s + Row M error handling + Row T test gaps + Row E infrastructure
…debase scan

- Vaulted: A1-A14, B1-B5, C1-C16, D1, A15-A41, S1-S19, M1-M9 (47 PRs)
- Added Row F (Form-not-function): 85 stub/form gaps from codebase scan
- Added Row T (Test coverage): 85 untested files mapped
- Added Rows M, S, D, E, H for remaining 72 cells
- README: added bounty badge + Bounty Bug Hunt section
- Total target: 400 cells (103 vaulted + 297 active)
F6: bare 'except Exception: pass' in inline query miners handler
F7: bare 'except Exception: pass' in inline query epoch handler

Both now log a warning with exc_info=True so silent failures
are observable without changing the fallthrough behaviour.

Also:
- Mark F3-F5 as FALSE POSITIVES (explorer-api pass is intentional,
  WalletCheckError exception class is standard Python)
- Update board: 107/400 cells vaulted, 49 PRs, 290 fresh gaps
Replace hardcoded TODO string with os.environ.get() fallback so
devnet deployments can set WRTC_MINT_DEVNET env var.
@github-actions github-actions Bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related api API endpoint related size/M PR: 51-200 lines labels May 25, 2026
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this PR. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API endpoint related BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) documentation Improvements or additions to documentation node Node server related size/M PR: 51-200 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants