test(bcos_pdf): add 37 unit tests for PDF certificate generator [T2]#6317
Open
waefrebeorn wants to merge 41 commits into
Open
test(bcos_pdf): add 37 unit tests for PDF certificate generator [T2]#6317waefrebeorn wants to merge 41 commits into
waefrebeorn wants to merge 41 commits into
Conversation
Adds max_length parameter to _clean_string_field and caps all user input fields in POST route handlers: - /lock: sender_wallet(128), target_wallet(128), tx_hash(128), receipt_signature(256) - /confirm: proof_ref(256), notes(1024) - /release: release_tx(128), notes(1024) Prevents storage of arbitrarily large strings in bridge_ledger DB.
…s + Row M error handling + Row T test gaps + Row E infrastructure
…debase scan - Vaulted: A1-A14, B1-B5, C1-C16, D1, A15-A41, S1-S19, M1-M9 (47 PRs) - Added Row F (Form-not-function): 85 stub/form gaps from codebase scan - Added Row T (Test coverage): 85 untested files mapped - Added Rows M, S, D, E, H for remaining 72 cells - README: added bounty badge + Bounty Bug Hunt section - Total target: 400 cells (103 vaulted + 297 active)
F6: bare 'except Exception: pass' in inline query miners handler F7: bare 'except Exception: pass' in inline query epoch handler Both now log a warning with exc_info=True so silent failures are observable without changing the fallthrough behaviour. Also: - Mark F3-F5 as FALSE POSITIVES (explorer-api pass is intentional, WalletCheckError exception class is standard Python) - Update board: 107/400 cells vaulted, 49 PRs, 290 fresh gaps
Covers: - PDF output validity (%PDF header, %%EOF, bytes return) - Full attestation content (cert_id, repo, tier, score, status, SHA, reviewer, commitment, signature split, signer key, anchor, coverage) - Minimal attestation edge cases (empty fields, no sig, no epoch) - tier_met=False -> REQUIREMENTS NOT MET - Score thresholds (high >=80, medium >=60, low <60) - Empty/partial score_breakdown - All 7 SCORE_WEIGHTS categories rendered - TIER_COLORS, SCORE_COLORS, SCORE_WEIGHTS constants 37 tests, all pass. Coverage: 0% -> covered (module-level constants + generate_certificate + BCOSCertificatePDF class). RTC: rtc17c0d21f04f6f65c1a85c0aeb5d4a305d57531096
github-actions
Bot
added
documentation
waefrebeorn
added a commit
to waefrebeorn/Rustchain
that referenced
this pull request
May 25, 2026
jaxint
approved these changes
May 25, 2026
Contributor
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Great work on this PR. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T2 — bcos_pdf.py test coverage
37 unit tests for
node/bcos_pdf.py— was 0% coverage, now covered.Test categories:
Key edge cases covered:
All 37 tests pass ✅
RTC Wallet: rtc17c0d21f04f6f65c1a85c0aeb5d4a305d57531096