Fixes edge-app delete
#235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_app` function panicked when trying to access the first element of the returned app list if the list was empty (e.g., app not found). This commit adds a check for an empty list in `get_app` and returns a `ResourceNotFound` error in that case. It also adds the `ResourceNotFound` variant to the `CommandError` enum.
sergey-borovkov
approved these changes
Apr 18, 2025
Contributor
Author
|
@sergey-borovkov This is the error this should address: thread 'main' panicked at src/api/edge_app/app.rs:76:61:
index out of bounds: the len is 0 but the index is 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a panic that occurred in the
get_appfunction within theedge-appAPI module. Previously, if the API call returned an empty list (indicating the requested edge app ID was not found), the code would attempt to access the first element of the empty list, causing anindex out of boundspanic.This change introduces a check for an empty list in
get_app. If the list is empty, it now returns aCommandError::ResourceNotFounderror. Additionally, theResourceNotFoundvariant has been added to theCommandErrorenum definition to support this.GitHub issue or Phabricator ticket number?
N/A
How has this been tested?
The full test suite was executed using
cargo testafter applying the changes, and all tests passed successfully. This verifies that the fix resolves the compilation error and integrates correctly with the existing codebase.