Add set_ne aliases to ActiveValue#3040
Merged
tyt2y3 merged 2 commits intoSeaQL:masterfrom Apr 8, 2026
Merged
Conversation
Contributor
Author
|
Note that |
Contributor
Author
|
Also, since |
Member
|
Actually, I prefer |
Expurple
reviewed
Apr 7, 2026
Member
Expurple
left a comment
There was a problem hiding this comment.
I slightly prefer set_ne over set_if_ne because it's shorter and clear enough to me.
Contributor
Author
|
Seems that there are different opinions on the short name, perhaps more opinions are needed :) |
Expurple
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
set_if_not_equals#2977Changes
ActiveValue::set_neas a shorter alias forset_if_not_equalsActiveValue::set_ne_andas a shorter alias forset_if_not_equals_andActiveValuedocs and examples in bothsea-ormandsea-orm-syncto prefer the shorter names