feat: Add TypeScript type annotations for PgVector columns#3041
Open
mansiverma897993 wants to merge 1 commit intoSeaQL:masterfrom
Open
feat: Add TypeScript type annotations for PgVector columns#3041mansiverma897993 wants to merge 1 commit intoSeaQL:masterfrom
mansiverma897993 wants to merge 1 commit intoSeaQL:masterfrom
Conversation
- Add get_ts_type_attrs method to Column to generate #[ts(type = "number[]")] or #[specta(type = "number[]")] attributes for PgVector fields when ts_rs::TS or specta::Type derives are present - Update all entity writers (compact, dense, expanded, frontend) to emit TS type attributes for vector columns - Add regression tests to ensure TS attributes are generated correctly - This fixes the issue where PgVector fields were not properly typed in generated TypeScript definitions
Member
|
Should this be fixed in codegen? Are there any limitations that prevent adding PgVector support in ts_rs and specta? |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
Bug Fixes
Breaking Changes
Changes