Visualizer support object and binary data types#28
Open
Aircoookie wants to merge 11 commits intoSendspin:mainfrom
Open
Visualizer support object and binary data types#28Aircoookie wants to merge 11 commits intoSendspin:mainfrom
Aircoookie wants to merge 11 commits intoSendspin:mainfrom
Conversation
Updated the visualizer support object structure and binary type details.
maximmaxim345
requested changes
Nov 19, 2025
Member
maximmaxim345
left a comment
There was a problem hiding this comment.
Hi @Aircoookie!
Thanks for the PR, sorry for taking so long to respond to you.
I have some suggestions on the architecture:
Splitting into multiple roles instead of tag-value encoding
Instead of a single visualizer role with tag-value encoded binary messages, I think it would be cleaner to split this into separate roles: visualize_beats, visualize_loudness, visualize_highest_amplitude, visualize_spectrum.
Benefits:
- Each role would have its own binary message type (we have 44 reserved message IDs for new roles)
- No need for tag-value encoding - the message format would be self-describing based on the message type
- Clients can still subscribe only to the specific visualizations they need
- Future-proofing: with PR #42, each visualization type can be versioned independently (e.g.,
visualize_spectrum@v2) without affecting the others
The only drawback I can think of is a slight overhead from receiving more WebSocket messages instead of bundled data - maybe resulting in at most 100 extra bytes per second, which isn't worth worrying about IMO.
Redundant bin count in Spectrum data
For the Spectrum/FFT data, the leading byte containing the bin count n seems redundant:
- The client already knows
n_disp_binsfrom thestream/startmessage - With separate roles, the client can calculate it from the WebSocket message length
Other than that, looks good to me!
String types (tentative) fixed binary format, no tag bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial draft of the proposed visualizer type specification, including the
visualizer_supportJSON object, as well as the binary message data type definitions.Feedback is highly appreciated!