[WIP] Fix/security vulnerabilities

.rubocop.yml

@@ -2,45 +2,47 @@
 # Built-in config:
 # https://github.com/bbatsov/rubocop/blob/master/config/default.yml
 
-# We do not typically use/need class documentation
-Documentation:
-  Enabled: false
+# # We do not typically use/need class documentation
+# Documentation:
+#   Enabled: false
 
-Metrics/LineLength:
-  Max: 120
+# Metrics/LineLength:
+#   Max: 120
 
-Metrics/ModuleLength:
-  Exclude:
-    - 'spec/**/*_spec.rb'
+# Metrics/ModuleLength:
+#   Exclude:
+#     - 'spec/**/*_spec.rb'
 
-Style/RaiseArgs:
-  Enabled: false
+# Style/RaiseArgs:
+#   Enabled: false
 
-Style/ClassAndModuleChildren:
-  Enabled: false
+# Style/ClassAndModuleChildren:
+#   Enabled: false
 
-Style/SingleLineBlockParams:
-  Enabled: false
+# Style/SingleLineBlockParams:
+#   Enabled: false
 
-Metrics/BlockLength:
-  Exclude:
-    - 'spec/**/*'
+# Metrics/BlockLength:
+#   Exclude:
+#     - 'spec/**/*'
+
+# Metrics/ParameterLists:
+#   Max: 6
 
-Metrics/ParameterLists:
-  Max: 6
+# Style/StringLiteralsInInterpolation:
+#   EnforcedStyle: single_quotes
 
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: single_quotes
+# Style/SymbolArray:
+#   EnforcedStyle: percent
+#   MinSize: 3
 
-Style/SymbolArray:
-  EnforcedStyle: percent
-  MinSize: 3
+# Style/SingleLineMethods:
+#   Enabled: false
 
-Style/SingleLineMethods:
-  Enabled: false
+# Rails:
+#   Enabled: true
 
-Rails:
-  Enabled: true
+require: rubocop-performance
 
 # Run rails specific checks
 AllCops:

.travis.yml

@@ -5,19 +5,48 @@ cache:
   yarn: true
   directories:
     - node_modules
+
+services:
+  -postgresql
+
+branches:
+  only:
+    - master
+
+addons:
+  postgresql: '10'
+  apt:
+    packages:
+      - postgresql-10
+      - postgresql-client-10
+      - postgresql-10-postgis-2.4
+      - postgresql-10-postgis-2.4-scripts
+env:
+  global:
+    - PGUSER=travis
+    - PGHOST=""
+    - PGPORT=5432
+
 before_install:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64  > ./cc-test-reporter
   - chmod +x ./cc-test-reporter
   - cp env-example .env
+
 install:
+  - nvm install 10
+  - npm i -g yarn
+  - gem install bundler
   - bundle install
   - yarn install
+
 script:
   - yarn test
   - RAILS_ENV=test bundle exec rake db:create db:migrate
   - bundle exec rspec
+
 after_script:
-- "./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT -t simplecov --id $CC_TEST_REPORTER_ID"
+  - "./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT -t simplecov --id $CC_TEST_REPORTER_ID"
+
 deploy:
   provider: heroku
   skip_cleanup: true
@@ -27,23 +56,11 @@ deploy:
     # dev: presencechecker-staging
     master: presence-prod
   run:
-  - bundle install
-  - yarn install
-  - bundle exec rake db:migrate
-  - bundle exec rake assets:precompile
-  - restart
+    - gem install bundler
+    - bundle install
+    - yarn install
+    - bundle exec rake db:migrate
+    - bundle exec rake assets:precompile
+    - restart
   api_key:
-    secure: omb+eniAp2kNU+FVCVWCdmMm+sDA5tSOUtB4CcQt7k+G4XOyLE5KxJEal8QqL6Ci3Zb3K9wwpmPrRNTCMajL2DAl7oQEKJQ/bW4kPD6eRJuSYe04X12GNKzgJHVPHkwag0fiJLHrwKQmfQHaapEnv/XtZCWYe6ceW7zjLHz4yDRAAZ+xCSY2W11EVnrNOc6vSFMcjGbGBnrkvQoTTtkh87AtmruB7Zu223CQuGtwmCNLY6+W7FPyQx2cctPAXhlyCteoX4UTFI2FRuI+18TxMQkJl0kbMMrxw2iO0OmcqC6pM0xOLnBWt/uK7OoduaAdK7jmQX+a8u6Vq/A+51zu1G1vbYoPKDRHvHFnO+gJH/fvt9k8NkDu8cVKrpnHz9U+ZQ8UztwevPtxqVnmbGy+3gtvWiRqfnHhOHeibnIPKqpZ83hdd3nitsv2nM+XiHSwLkeaBn4fjaxcHhG2QaoVAJVFqW1SLKZfQX0xah2ol/TIoQqf+IO28/BE/GBpyFtVzvwzQmd0etQIdc5EHoKezB8euBqyt32pk7c9bdQkVELJ3rqUompoDUifMNuQgY70KnPAvhcZJNTmSIWN0O5Up0ypueFSo8aCScNtVu9SOdmRLTi3swpebjPiTYjHaadzWDmrd9+2nHoYqhyQDhJyGOve0blM3sSBFQR3QE279J4=
-
-addons:
-  postgresql: 10
-  apt:
-    packages:
-      - postgresql-10-postgis-2.4
-      - postgresql-10-postgis-2.4-scripts
-      - postgresql-client-10
-env:
-  global:
-    - PGUSER=travis
-    - PGHOST=""
-    - PGPORT=5432
+    secure: omb+eniAp2kNU+FVCVWCdmMm+sDA5tSOUtB4CcQt7k+G4XOyLE5KxJEal8QqL6Ci3Zb3K9wwpmPrRNTCMajL2DAl7oQEKJQ/bW4kPD6eRJuSYe04X12GNKzgJHVPHkwag0fiJLHrwKQmfQHaapEnv/XtZCWYe6ceW7zjLHz4yDRAAZ+xCSY2W11EVnrNOc6vSFMcjGbGBnrkvQoTTtkh87AtmruB7Zu223CQuGtwmCNLY6+W7FPyQx2cctPAXhlyCteoX4UTFI2FRuI+18TxMQkJl0kbMMrxw2iO0OmcqC6pM0xOLnBWt/uK7OoduaAdK7jmQX+a8u6Vq/A+51zu1G1vbYoPKDRHvHFnO+gJH/fvt9k8NkDu8cVKrpnHz9U+ZQ8UztwevPtxqVnmbGy+3gtvWiRqfnHhOHeibnIPKqpZ83hdd3nitsv2nM+XiHSwLkeaBn4fjaxcHhG2QaoVAJVFqW1SLKZfQX0xah2ol/TIoQqf+IO28/BE/GBpyFtVzvwzQmd0etQIdc5EHoKezB8euBqyt32pk7c9bdQkVELJ3rqUompoDUifMNuQgY70KnPAvhcZJNTmSIWN0O5Up0ypueFSo8aCScNtVu9SOdmRLTi3swpebjPiTYjHaadzWDmrd9+2nHoYqhyQDhJyGOve0blM3sSBFQR3QE279J4=

Gemfile

@@ -61,7 +61,9 @@ group :development, :test do
   # freeze times in tests
   gem 'timecop'
 
-  gem 'rubocop', '0.68.1'
+  # Performance Cops will be removed from RuboCop 0.68. Use rubocop-performance gem instead.
+  # gem 'rubocop', '0.68.1'
+  gem 'rubocop-performance'
 end
 
 group :development do
@@ -84,8 +86,9 @@ group :test do
   # Adds support for Capybara system testing and selenium driver
   gem 'capybara', '>= 2.15'
   gem 'selenium-webdriver'
-  # Easy installation and use of chromedriver to run system tests with Chrome
-  gem 'chromedriver-helper'
+  # DEPRECIATED - Easy installation and use of chromedriver to run system tests with Chrome
+  # gem 'chromedriver-helper'
+  gem 'webdrivers', '~> 4.0'
   # Coverage
   gem 'simplecov'
   # test framework

Gemfile.lock

@@ -54,8 +54,6 @@ GEM
       request_store
       safely_block (>= 0.2.1)
       user_agent_parser
-    archive-zip (0.12.0)
-      io-like (~> 0.3.0)
     arel (9.0.0)
     ast (2.4.0)
     bcrypt (3.1.13)
@@ -76,9 +74,6 @@ GEM
     childprocess (1.0.1)
       rake (< 13.0)
     choice (0.2.0)
-    chromedriver-helper (2.1.1)
-      archive-zip (~> 0.10)
-      nokogiri (~> 1.8)
     coffee-rails (5.0.0)
       coffee-script (>= 2.2.0)
       railties (>= 5.2.0)
@@ -127,7 +122,6 @@ GEM
       multi_xml (>= 0.5.2)
     i18n (1.7.0)
       concurrent-ruby (~> 1.0)
-    io-like (0.3.0)
     jaro_winkler (1.5.4)
     jbuilder (2.8.0)
       activesupport (>= 4.2.0)
@@ -179,7 +173,7 @@ GEM
       mini_portile2 (~> 2.4.0)
     orm_adapter (0.5.0)
     parallel (1.19.1)
-    parser (2.6.5.0)
+    parser (2.7.0.2)
       ast (~> 2.4.0)
     pg (1.1.4)
     public_suffix (3.0.3)
@@ -257,13 +251,15 @@ GEM
       rspec-mocks (~> 3.8.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.0)
-    rubocop (0.68.1)
+    rubocop (0.79.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
+      parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.6)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-performance (1.5.2)
+      rubocop (>= 0.71.0)
     ruby-graphviz (1.2.4)
       unicode-display_width (>= 1.4.0, < 1.6)
     ruby-progressbar (1.10.1)
@@ -326,6 +322,10 @@ GEM
       activemodel (>= 5.0)
       bindex (>= 0.4.0)
       railties (>= 5.0)
+    webdrivers (4.2.0)
+      nokogiri (~> 1.6)
+      rubyzip (>= 1.3.0)
+      selenium-webdriver (>= 3.0, < 4.0)
     webpacker (3.6.0)
       activesupport (>= 4.2)
       rack-proxy (>= 0.6.1)
@@ -344,7 +344,6 @@ DEPENDENCIES
   bootsnap (>= 1.1.0)
   byebug
   capybara (>= 2.15)
-  chromedriver-helper
   coffee-rails (~> 5.0)
   devise
   devise_invitable (~> 2.0.1)
@@ -365,7 +364,7 @@ DEPENDENCIES
   rails-erd
   react_on_rails
   rspec-rails
-  rubocop (= 0.68.1)
+  rubocop-performance
   sass-rails (~> 5.0)
   seed_dump
   selenium-webdriver
@@ -376,10 +375,11 @@ DEPENDENCIES
   turbolinks (~> 5)
   uglifier (>= 1.3.0)
   web-console (>= 3.3.0)
+  webdrivers (~> 4.0)
   webpacker
 
 RUBY VERSION
    ruby 2.5.3p105
 
 BUNDLED WITH
-   1.17.3
+   2.1.4

config/environments/production.rb

@@ -64,7 +64,8 @@
 
   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
   # the I18n.default_locale when a translation cannot be found).
-  config.i18n.fallbacks = true
+  # Breaking Change - https://github.com/ruby-i18n/i18n/releases/tag/v1.1.0
+  config.i18n.fallbacks = [I18n.default_locale]
 
   # Send deprecation notices to registered listeners.
   config.active_support.deprecation = :notify