This repository was archived by the owner on Nov 16, 2019. It is now read-only.
[WIP] fix/rr325-change-order-of-content-and-labels#339
Open
[WIP] fix/rr325-change-order-of-content-and-labels#339
Conversation
JacOng17
requested review from
Br3nda,
CaraHill,
dlouise64,
lamorrison and
mischa-s
JacOng17
changed the title
mischa-s
approved these changes
Jun 4, 2019
dlouise64
approved these changes
Jun 4, 2019
….com:ServiceInnovationLab/pancake-backend into fix/rr325-change-order-of-content-and-labels
JacOng17
changed the title
JacOng17
changed the title
Contributor
|
@JacOng17 what is this waiting on? |
Contributor
Author
|
@mischa-s Have DM-ed you. Needs a potential code re-write? before it can be merged. |
Contributor
|
This was a good implementation but #380 is simpler so lets go with that |
Br3nda
previously approved these changes
Jul 1, 2019
Collaborator
|
@JacOng17 / @robholmesnz shall we close this one? Or is it still needed. |
Contributor
Author
|
@Br3nda PM u |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why?
Rearranged fields & added new field- Work and Income benefits.
How to test this change
Not too sure where that field is getting it's data from, but just adding it in to match the design.
After changes:
