Skip to content

Add autogen for AMDC article in control with AMDC folder#151

Open
Daehoon-Sung wants to merge 77 commits intomainfrom
feature/add-autogen-control-with-AMDC-article
Open

Add autogen for AMDC article in control with AMDC folder#151
Daehoon-Sung wants to merge 77 commits intomainfrom
feature/add-autogen-control-with-AMDC-article

Conversation

@Daehoon-Sung
Copy link
Copy Markdown
Contributor

@Daehoon-Sung Daehoon-Sung commented Mar 19, 2026

This is to close #143 to close #149 to close https://github.com/Severson-Group/AMDC-Examples/issues/6.

Notes

This comment might be useful to refer to how we came up with the plan for those two ariticles.

Self-Review

In this section, please self-review (answer all questions) on a suitable review checklist prior to requesting review from others. Select a review checklist based on what content is being merged in; see the Review Checklists section.

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

Standard checklist

1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

@Daehoon-Sung
Copy link
Copy Markdown
Contributor Author

Hello Professor @elsevers. Regarding this comment, we created an article that includes "Control with AMDC" article on Autogen.

Could you review this article, Professor?
Thank you.

@Daehoon-Sung
Copy link
Copy Markdown
Contributor Author

Hello Professor @elsevers. This is a friendly reminder. Could you review this article when you have time?
Thank you.

@Daehoon-Sung
Copy link
Copy Markdown
Contributor Author

Hello Professor @elsevers. This is a friendly reminder. Could you review this article when you have time?
Thank you.

@noguchi-takahiro
Copy link
Copy Markdown
Contributor

Here is the rendered version: Control with AMDC Using Simulink Autogen - AMDC Platform.pdf.

Copy link
Copy Markdown
Contributor

@noguchi-takahiro noguchi-takahiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per 4/3, we want to include links to MATLAB documentation so that the reader can refer to.


## Development Environment and Workflow

To develop control code using Simulink Autogen, the following software components are required:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "software components" can be different term, maybe library or add-on, or toolbox.

2. Call the controller step function
3. Route outputs to actuators (e.g., PWM duty cycles)

The generated code has the following structure:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated code here means Autogen code. But this is telling us that the following code is generated via Autogen, which is not true.

Copy link
Copy Markdown
Contributor

@noguchi-takahiro noguchi-takahiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per 4/10:

@Daehoon-Sung will focus on this article and do the following

  • Try simplifying the Background
  • Link resources to MATLAB documentation (e.g., discrete time block documentation and model reference)
  • Create a block diagram to explain input/output, controller, plant, etc. Try editing this figure otherwise use Power point.

@noguchi-takahiro will focus on this article and finalize tutorial.

@noguchi-takahiro
Copy link
Copy Markdown
Contributor

noguchi-takahiro commented Apr 11, 2026

@Daehoon-Sung I updated the tutorial part. Here is the rendering version of the article: Tutorial_ Autogen - AMDC Platform.pdf. After you finalize the article, you want to compare these files to make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add AMDC article of Autogen in "Control with AMDC" section Add AMDC tutorial article using Simulink Autogen

2 participants