Remove legacy app schema #6612
Open
Remove legacy app schema #6612
+650
−1,010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaloriestra
force-pushed
the
remove-legacy-schema
branch
from
a720cd9 to
dbb7bd3
Compare
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3691 tests passing in 1434 suites. Report generated by 🧪jest coverage report action from 6d16a4a |
gonzaloriestra
force-pushed
the
remove-legacy-schema
branch
from
dbb7bd3 to
3cc6b58
Compare
Contributor
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
gonzaloriestra
added
stale-exempt
gonzaloriestra
force-pushed
the
remove-legacy-schema
branch
from
3cc6b58 to
28c8da5
Compare
5 tasks
gonzaloriestra
force-pushed
the
remove-legacy-schema
branch
from
28c8da5 to
1ff8979
Compare
gonzaloriestra
force-pushed
the
remove-legacy-schema
branch
5 times, most recently
from
2c41f40 to
48c5296
Compare
This was referenced Feb 4, 2026
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
gonzaloriestra
commented
Feb 5, 2026
Comment on lines
-89
to
-93
| // Ensure shopify.app.toml exists in the app directory | ||
| await ensureAppToml(this.appDirectory) | ||
|
|
||
| // Ensure package.json exists in the app directory | ||
| await ensurePackageJson(this.appDirectory) |
Contributor
Author
There was a problem hiding this comment.
We were adding a default TOML and Json if for some reason they were not created, but that would mask actual errors.
gonzaloriestra
force-pushed
the
remove-legacy-schema
branch
from
48c5296 to
6d16a4a
Compare
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260205101033Caution After installing, validate the version by running just |
This was referenced Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We have a lot of code to support the legacy app schema in the CLI and templates, but that schema only works for the template state (before linking), so it doesn't make sense to keep it.
The subscriptions-reference-app template was ready.
WHAT is this pull request doing?
client_idrequired in app schema (templates must includeclient_id = "")[access_scopes]section)How to test your changes?
npm i -g @shopify/cli@0.0.0-snapshot-20260205101033shopify app init --template=https://github.com/Shopify/shopify-app-template-react-router#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-none#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-remix#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-ruby#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-node#add-client-id-to-tomlshopify app init --template=https://github.com/Shopify/shopify-app-template-php#add-client-id-to-tomlshopify app init --template https://github.com/Shopify/shopify-app-template-react-router#include-declarative-definition(related to Support flexible templates forapp init#6751)shopify app dev,shopify app deploy...Measuring impact
How do we know this change was effective? Please choose one:
Checklist