Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

chore: pkg import only once#574

Open
testwill wants to merge 1 commit into
Shopify:mainfrom
testwill:pkg-import
Open

chore: pkg import only once#574
testwill wants to merge 1 commit into
Shopify:mainfrom
testwill:pkg-import

Conversation

@testwill
Copy link
Copy Markdown

Description

Fixes # (issue)

Type of change
  • Bug fix 🐛
  • New feature ✨
  • This change requires a documentation update 📖
  • Breaking changes ⚠️
How Has This Been Tested?
  • Test A
  • Test B
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
Comment thread example_test.go

// Print results as JSON
report.PrintResults(kubeaudit.WithFormatter(&logrus.JSONFormatter{}))
report.PrintResults(kubeaudit.WithFormatter(&log.JSONFormatter{}))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Copy Markdown
Contributor

@dani-santos-code dani-santos-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! thanks for your contribution. Would you mind adding a little description in the PR and also signing the CLA?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants