Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

build static binaries (#579)#580

Closed
robinelfrink wants to merge 1 commit into
Shopify:mainfrom
equinix-ms:main
Closed

build static binaries (#579)#580
robinelfrink wants to merge 1 commit into
Shopify:mainfrom
equinix-ms:main

Conversation

@robinelfrink
Copy link
Copy Markdown

@robinelfrink robinelfrink commented Feb 2, 2024

Description

Make gorelease build sstatic binaries, instead of dynamically linked. This ensures the binaries are useable on (almost) any version and variations of operating systems the binaries are built for, and also makes sure the docker container has a static binary.

Fixes #579

Type of change
  • Bug fix 🐛
Checklist:
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

I will not sign the CLA, as it wants my home address, and I think that is completely irrelevant.

I hereby grant Shopify the right to simply copy the line I added to .goreleaser.yml.

@dani-santos-code
Copy link
Copy Markdown
Contributor

hi, @robinelfrink ! thank you for your contribution. Can you sign the CLA here? https://cla.shopify.com/

@robinelfrink
Copy link
Copy Markdown
Author

Hi @dani-santos-code,

hi, @robinelfrink ! thank you for your contribution. Can you sign the CLA here? https://cla.shopify.com/

No, I cannot. The form wants my home address. I don't see how that is relevant.

@BoBeR182
Copy link
Copy Markdown

I signed the CLA and submitted the patch.
#592

@equinix-ms equinix-ms closed this by deleting the head repository Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker container at ghcr.io is missing libraries - dynamically linked kubeaudit binary

4 participants