Skip to content

Require Sorbet 0.6+ for T::Module#2575

Open
bdewater-thatch wants to merge 1 commit intoShopify:mainfrom
thatch-health:sorbet-06
Open

Require Sorbet 0.6+ for T::Module#2575
bdewater-thatch wants to merge 1 commit intoShopify:mainfrom
thatch-health:sorbet-06

Conversation

@bdewater-thatch
Copy link
Copy Markdown
Contributor

Motivation

Tapioca 0.18.0 and 0.19.0 crash when running with Sorbet 0.5.x:

Loading DSL compiler classes... /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/tapioca-0.19.0/lib/tapioca/dsl/compilers/url_helpers.rb:134:in 'block in singleton class': uninitialized constant T::Module (NameError)

            own_ancestors = if Class === mod && (superclass = superclass_of(mod))
                               ^^^^^
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/sorbet-runtime-0.5.12443/lib/types/private/methods/_methods.rb:360:in 'BasicObject#instance_exec'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/sorbet-runtime-0.5.12443/lib/types/private/methods/_methods.rb:360:in 'T::Private::Methods.run_builder'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/sorbet-runtime-0.5.12443/lib/types/private/methods/_methods.rb:338:in 'T::Private::Methods.run_sig'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/sorbet-runtime-0.5.12443/lib/types/private/methods/_methods.rb:248:in 'block in T::Private::Methods._on_method_added'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/sorbet-runtime-0.5.12443/lib/types/private/methods/_methods.rb:449:in 'T::Private::Methods.run_sig_block_for_key'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/sorbet-runtime-0.5.12443/lib/types/private/methods/_methods.rb:429:in 'T::Private::Methods.maybe_run_sig_block_for_key'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/sorbet-runtime-0.5.12443/lib/types/private/methods/_methods.rb:258:in 'block in Tapioca::Dsl::Compilers::UrlHelpers._on_method_added'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/tapioca-0.19.0/lib/tapioca/dsl/compilers/url_helpers.rb:164:in '<class:UrlHelpers>'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/tapioca-0.19.0/lib/tapioca/dsl/compilers/url_helpers.rb:81:in '<module:Compilers>'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/tapioca-0.19.0/lib/tapioca/dsl/compilers/url_helpers.rb:8:in '<module:Dsl>'
        from /Users/bdewater/.rbenv/versions/4.0.2/lib/ruby/gems/4.0.0/gems/tapioca-0.19.0/lib/tapioca/dsl/compilers/url_helpers.rb:7:in '<module:Tapioca>'

Similar to angellist/boba#21

@bdewater-thatch bdewater-thatch requested a review from a team as a code owner April 2, 2026 21:15
@@ -22,7 +22,7 @@ PATH
rbi (>= 0.3.7)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I wonder if this needs to be bumped too: https://github.com/Shopify/rbi/releases/tag/v0.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant