Bump minitest and cleanup as minitest 6 is now widely supported#2578
Open
larouxn wants to merge 1 commit intoShopify:mainfrom
Open
Bump minitest and cleanup as minitest 6 is now widely supported#2578larouxn wants to merge 1 commit intoShopify:mainfrom
larouxn wants to merge 1 commit intoShopify:mainfrom
Conversation
larouxn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Proposing we clean up some of the complications and changes we added to our spec helper in order to conditionally use Minitest 6 as until recently Rails 8.1 supported it Minitest 6 but Rails 8.0 did not. This is all possible now that Rails 8.0.5 and minitest-reporters 1.8.0 are out .
Follow up to
Implementation
Mostly a semi-revert of the temporary changes made in the above two PRs.
Tests
CI should prove if everything is working well. Have run such myself over here and all looks good.
https://github.com/larouxn/tapioca/actions/runs/23947725345/job/69847547756 (regen-ed RBIs since this run)