-
Notifications
You must be signed in to change notification settings - Fork 156
Patch Void type handling in Sorbet runtime for correct return types
#2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paracycle
wants to merge
1
commit into
main
Choose a base branch
from
uk-fix-void-checked-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # typed: true | ||
| # frozen_string_literal: true | ||
|
|
||
| # If Signature has `effective_return_type`, then `return_type` always returns the correct type. | ||
| # Ref: https://github.com/sorbet/sorbet/pull/10121 | ||
| return if T::Private::Methods::Signature.method_defined?(:effective_return_type) | ||
|
|
||
| module T | ||
| module Private | ||
| module Methods | ||
| module DeclBuilderPatch | ||
| def void | ||
| super.tap do | ||
| @_real_returns_is_void = true | ||
| end | ||
| end | ||
|
|
||
| def finalize! | ||
| super.tap do | ||
| #: self as untyped | ||
| decl.returns = T::Private::Types::Void::Private::INSTANCE if @_real_returns_is_void | ||
| end | ||
| end | ||
| end | ||
|
|
||
| DeclBuilder.prepend(DeclBuilderPatch) | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, I think we could move this strategy into sorbet-runtime itself, and avoid having to patch it here. I think that adding one more
true/falseinstance variable to theSignaturedata structure would not cause an increase in memory usage because of the way that Ruby buckets objects with N instance variables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, something like this I assume: sorbet/sorbet#10121
I think I'll still merge this and then, later on, make the patching conditional on the existence of
Signature#real_return_typemethod.