2023 07 admin path#3875
Merged
laurelthorburn merged 2 commits into2023-07from Feb 10, 2026
Merged
Conversation
johndcollett
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary: Admin docs build fixes and shopify-dev copy
What changed
1. Admin docs build script (
docs/surfaces/admin/build-docs.sh)fail_and_exitwithexit $build_exitso the script exits with the right status when the doc build fails.../../../shopify-dev(same pattern as checkout docs).shopify-dev/.../templated_apis/admin_extensions/<API_VERSION>/. Version is controlled byAPI_VERSIONor the second script argument (defaultunstable).https://shopify.devfromgenerated_docs_data.jsonbefore copy so links work in Spin; for non-unstableversions, replace/unstablewith the version in doc links.2. generate-docs “Unable to find code file” fix
generate-docstreats everycodefield as a file path. The Custom Protocols section used inline snippets (e.g.'<Link to="shopify:admin/..." />'), which were interpreted as paths and failed.staticPages/examples/and pointed the doc at them:link-shopify-admin.tsx,fetch-shopify-admin.ts,link-app.tsx,link-extension.tsx,link-relative.tsxadmin-extensions.doc.tsso all Custom Protocols codeblocks use these file paths instead of inline code strings.Result
yarn docs:admin(andAPI_VERSION=2023-07 yarn docs:admin) completes successfully.