Included more Python Versions in CI#258
Open
rpartzsch wants to merge 1 commit intoSiLab-Bonn:masterfrom
Open
Conversation
1ccd7e1 to
b5f8c33
Compare
cbespin
requested changes
Mar 19, 2026
Comment on lines
41
to
42
| - sim: icarus | ||
| python-version: '3.11' |
Contributor
There was a problem hiding this comment.
The tests fail because the SIM env variable is not defined for all tested Python versions. I think we need more blocks such as this and/or check if this syntax can be simplified. Thanks to conda-forge, the verilator install is so fast that we could test more Python versions with verilator as well, although the benefits are very small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just expanded the CI Python version matrix. In response to #248.