Strip script nodes from lyrics soup #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

eantelman wants to merge 5 commits into SimonIT:master from eantelman:issue-34

eantelman commented Jan 17, 2021 •

edited by SimonIT

Loading

fixes #34

eantelman added 4 commits

January 17, 2021 17:34


          Strip script nodes from lyrics soup

e1705b9


          Strip script nodes from lyrics soup

96bd82b


          Merge branch 'issue-34' of https://github.com/eantelman/spotifylyrics …

799e828

…into issue-34


          From sentry-sdk changelog. 0.19.0

aeebce4

Removed _experiments.auto_enabling_integrations in favor of just auto_enabling_integrations which is now enabled by default.

Author

eantelman commented Jan 17, 2021

Needed version update of sentry-sdk in requirements.

Owner

SimonIT commented Jan 18, 2021

Hi, thanks for the PR.
Do you mind to explain the issue you are fixing in more detail?
I hadn't any issues with songmeanings and I don't see what removing script elements from the html can fix


          Duh two paths. For obvious testing, 'http://songmeanings.com/m/query/…

dbbc71f

…?q=Veruca Salt Blissful Queen'

SimonIT added the question label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels