Skip to content

ci: Make Code quality check run pre-commit#619

Merged
ValerianRey merged 4 commits intomainfrom
run-pre-commit-in-checks
Mar 6, 2026
Merged

ci: Make Code quality check run pre-commit#619
ValerianRey merged 4 commits intomainfrom
run-pre-commit-in-checks

Conversation

@ValerianRey
Copy link
Contributor

@ValerianRey ValerianRey commented Mar 6, 2026

The idea is:

Disadvantages:

  • This is slower: setting up the hook takes 9 seconds, but it's instant with pre-commit ci due to caching I think. I don't think this is a problem because this action is still faster than any of the test actions.
  • We lose autofixing (if a contributor commits without pre-commit installed, pre-commit ci can autofix their PR after we allow ci to run)

Advantages:

  • We stop depending on pre-commit ci, which frequently does not run for no reason, and could stop being free one day.

Fun fact: pre-commit ci doesn't run on this PR for no apparent reason. EDIT: it did after a long while

@ValerianRey ValerianRey added the cc: ci Conventional commit type for changes to the CI (Github workflows and actions). label Mar 6, 2026
@ValerianRey ValerianRey self-assigned this Mar 6, 2026
@github-actions github-actions bot changed the title Make Code quality check run pre-commit ci: Make Code quality check run pre-commit Mar 6, 2026
@ValerianRey ValerianRey merged commit 2c8a3cb into main Mar 6, 2026
17 checks passed
@ValerianRey ValerianRey deleted the run-pre-commit-in-checks branch March 6, 2026 14:42
@PierreQuinton
Copy link
Contributor

@ValerianRey This deleted ruff checks.

@ValerianRey
Copy link
Contributor Author

@ValerianRey This deleted ruff checks.

Are you sure? They should be run by pre-commit (it has ruff check and ruff format hooks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: ci Conventional commit type for changes to the CI (Github workflows and actions).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants