Fix lint errors in preparation for ESLint 10#1103
Merged
Conversation
- Fix no-useless-assignment in sk_types.ts (use `let res: number` instead of `let res = 0`)
- Fix prefer-nullish-coalescing in sk_types.ts and index.ts (use `??` and `??=`)
- Fix jsdoc/require-throws-type in api.ts and rest.ts (use `{Type}` syntax)
- Fix jsdoc/escape-inline-tags in index.ts (backtick-escape package names)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
mbouaziz
added a commit
that referenced
this pull request
Feb 21, 2026
## Summary - Bump ESLint from 9.15.0 to 10.0.0 and minimatch from 9.0.5 to 10.0.1 - Update shared `@skiplabs/eslint-config` dependencies for ESLint 10 compatibility (`@eslint/js` ^10, `@stylistic/eslint-plugin-js` ^4, `eslint-plugin-jsdoc` ^62, `typescript-eslint` ^8.56) - Remove `/* eslint-env node */` comments from example `server.js` files (ESLint 10 errors on these; globals are already declared in `eslint.config.js`) - Regenerate `package-lock.json` and `examples/cache_invalidation/edge_service/pnpm-lock.yaml` ## Notes - Depends on #1103 (lint fixes that are valid on both ESLint 9 and 10) - `eslint-plugin-jsdoc` doesn't declare ESLint 10 in peer deps yet (`^7 || ^8 || ^9`) but works in practice - `@stylistic/eslint-plugin-js` emits a deprecation warning recommending migration to `@stylistic/eslint-plugin` (not blocking) ## Test plan - [x] `make check-ts` build + lint passes for all workspaces (only pre-existing `skc` wasm build failure remains, unrelated to ESLint) - [x] Example workspaces (`cache_invalidation/edge_service`, `blogger/reactive_service`) lint clean 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-useless-assignmentinsk_types.ts(uselet res: numberinstead oflet res = 0)prefer-nullish-coalescinginsk_types.tsandindex.ts(use??and??=)jsdoc/require-throws-typeinapi.tsandrest.ts(use{Type}syntax)jsdoc/escape-inline-tagsinindex.ts(backtick-escape package names in JSDoc)These are valid lint improvements that pass with current ESLint 9 and unblock the ESLint 10 upgrade (#1101).
Test plan
make check-tspasses (all build + lint) — only pre-existingskcwasm build failure remains🤖 Generated with Claude Code