removed HDOP from Nominal documentation as its is missing from GPSFix… #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_cfg.h
Hi,
I think there may be a documentation or config error.
The documentation suggests the nominal config reports HDOP, yet it is commented out in the GPSfix_cfg.h
//#define GPS_FIX_HDOPSee; https://github.com/SlashDevin/NeoGPS/blob/master/extras/configs/Nominal/GPSfix_cfg.h#L27
This pull request corrects the documentation - an alternative is to uncomment that line, as the correct sentences
#define NMEAGPS_PARSE_GGAare configured in;https://github.com/SlashDevin/NeoGPS/blob/master/extras/configs/Nominal/NMEAGPS_cfg.h#L14