Added WebView native template element#97
Open
scorsin-oai wants to merge 1 commit into
Open
Conversation
## Description This change adds webview as a builtin native template element. It is implemented through the new polyglot module system we introduced for open sourcing, which allows to provide new native views with their TS API in their own isolated modules and have them being automatically discoverable by the Valdi runtime. It works on both iOS and Android. The API is exposed through a WebViewController API which is code generated. The controller can be attached when rendered under a `<webview>` element. Added also a sample app which showcases the API. (cherry picked from commit 73f32a0c05fe45dcc69a020ea59fa96b0b367a20)
github-actions
Bot
added
area/build-system
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thanks for your first contribution to Valdi!
A maintainer will review your PR soon. Here are a few things to check while you wait:
- ✅ All tests pass (
bazel test //...) - ✅ Your changes follow our coding standards
- ✅ You've added tests for your changes (if applicable)
- ✅ You've updated documentation (if needed)
Join our Discord community if you have questions!
|
Semgrep found 23
This literal might contain a Snapchat internal reference that should not be committed to open-source repositories. Fix: Please replace / remove the string to avoid committing it to open-source repositories. |
Collaborator
|
Pulling in for extra testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds webview as a builtin native template element. It is implemented through the new polyglot module system, which allows to provide new native views with their TS API in their own isolated modules and have them being automatically discoverable by the Valdi runtime. It works on both iOS and Android. The API is exposed through a WebViewController API which is code generated. The controller can be attached when rendered under a
<webview>element. Added also a sample app which showcases the API.Type of Change
Testing
bazel test //...)Testing Details
Checklist
Related Issues
Additional Context