Added support for generating app icons (#104)#99
Open
scorsin-oai wants to merge 1 commit into
Open
Conversation
## Description
This change adds support for generating app icons at build time, that we
can just do:
```python
valdi_application(
name = "hello_world",
icons = valdi_application_icons(src = "app_assets/icon.svg"),
# [redacted]
)
```
and the icon gets generated for each platform depending on what we are
compiling for, in different variants. Codex can quickly generate SVGs
for the icons for the sample apps it makes, it will avoid having a large
list of sample apps with default icons.
## Type of Change
- [ ] Bug fix (non-breaking change that fixes an issue)
- [ ] Documentation improvement
- [ ] Performance optimization
- [ ] Test improvement
- [ ] Other (please describe)
## Testing
- [ ] Tests pass locally (`bazel test //...`)
- [ ] Added/updated tests for changes (if applicable)
- [ ] Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
- [ ] Manual testing performed (describe below)
### Testing Details
<!-- Describe the testing you performed -->
## Checklist
- [ ] Code follows project style guidelines
- [ ] Documentation updated (if needed)
- [ ] No breaking changes (or documented in description)
- [ ] Commit messages follow [conventional
format](../CONTRIBUTING.md#commit-messages)
- [ ] No secrets, API keys, or internal URLs included
## Related Issues
<!-- Link related issues using: Closes #(issue), Fixes #(issue), Relates
to #(issue) -->
## Additional Context
<!-- Add any other context, screenshots, or information that would help
reviewers -->
(cherry picked from commit 4c867976ed487735998f87583c682a62e62028dd)
github-actions
Bot
added
area/build-system
Sensitive Files Detected🔧 Build rules — Affects build rules for all Valdi consumers. This is an automated notice. A maintainer will review after import. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for generating app icons at build time, that we can just do:
and the icon gets generated for each platform depending on what we are compiling for, in different variants. Coding agents like Codex can quickly generate SVGs for the sample apps it makes. It will avoid having a large list of sample apps with default icons.
Type of Change
Testing
bazel test //...)Testing Details
Checklist
Related Issues
Additional Context
(cherry picked from commit 4c867976ed487735998f87583c682a62e62028dd)
Description
Type of Change
Testing
bazel test //...)Testing Details
Checklist
Related Issues
Additional Context