test: add COPY INTO, LATERAL FLATTEN, and additional Snowflake dialect test coverage#173
Merged
sfc-gh-twhite merged 1 commit intoSnowflake-Labs:mainfrom Apr 2, 2026
Conversation
12a93c7 to
77273d6
Compare
|
Oooo, would this also separate SHOW out to its own setting option instead of bucketing it under command?!! If so, PLEASE APPROVE |
|
Ah I think I have duplicated this PR ! We came to the same conclusion! #179 |
2 tasks
77273d6 to
047fbbd
Compare
…t test coverage Add tests for Snowflake-specific syntax not covered by Snowflake-Labs#170: COPY INTO, LATERAL FLATTEN, nested dot-path notation, bracket notation, OBJECT_CONSTRUCT, and GET_PATH. Also add Copy to the README permissions example so users can configure it explicitly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
047fbbd to
7ca9fcd
Compare
Contributor
Author
|
Sounds good @sfc-gh-twhite I rebased and updated the PR with the additional test coverage (COPY INTO, LATERAL FLATTEN, nested dot-path, bracket notation, OBJECT_CONSTRUCT, GET_PATH) and added Copy in the README permissions example. |
sfc-gh-twhite
approved these changes
Apr 2, 2026
Collaborator
sfc-gh-twhite
left a comment
There was a problem hiding this comment.
Thanks for the submission! Appreciate you rebasing after #170 to include your test for COPY INTO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #170 — adds test coverage for Snowflake-specific syntax that isn't covered by the existing tests:
Copy, notUnknown(the original issue in COPY statements incorrectly classified as "Unknown" instead of "Copy" #161)data:user.address.city::STRING)data['key'])Also adds
Copyto thesql_statement_permissionsexample in the README so users know they can configure it explicitly.Test plan
TestSnowflakeSpecificSyntaxclass passes (7 parametrized + 1 COPY INTO)🤖 Generated with Claude Code