Add integration tests for the contract upgrade#1749
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
=======================================
Coverage 76.90% 76.90%
=======================================
Files 24 24
Lines 983 983
Branches 186 186
=======================================
Hits 756 756
Misses 203 203
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrong
changed the title
| "1000": "https://polkadot-asset-hub-rpc.polkadot.io", | ||
| "1002": "https://polkadot-bridge-hub-rpc.polkadot.io", |
There was a problem hiding this comment.
I encountered an issue where a V2 transfer from AH to Ethereum fails using Dwellir endpoints (although the dry run succeeds), but works when switching to Parity endpoints.
There was a problem hiding this comment.
This is fine, but we cannot use https, we must use wss. This is because there is an issue with @polkadot/api where https does not receive event notifications for tx finalized which we use.
| @@ -27,8 +27,8 @@ import { | |||
| Command, | |||
| TokenInfo, | |||
| MintForeignTokenParams | |||
| } from "../../src/v1/Types.sol"; | |||
| import {MultiAddress, multiAddressFromBytes32} from "../../src/v1/MultiAddress.sol"; | |||
| } from "../src/v1/Types.sol"; | |||
There was a problem hiding this comment.
Can simplify to:
import {
UpgradeParams, SetOperatingModeParams, OperatingMode,
RegisterForeignTokenParams, ChannelID, ParaID,
InboundMessage, Command, TokenInfo, MintForeignTokenParams
} from "../src/v1/Types.sol";
| function selectFork24677447() public { | ||
| vm.createSelectFork( | ||
| "https://virtual.mainnet.eu.rpc.tenderly.co/a2b5dc8d-c06a-40a9-b893-d86dc7c9ecd4", | ||
| 24_677_447 | ||
| ); | ||
| } | ||
|
|
||
| function selectFork24681921() public { | ||
| vm.createSelectFork( | ||
| "https://virtual.mainnet.eu.rpc.tenderly.co/390efc23-bb26-460c-b641-b5275f790bd7", | ||
| 24_681_921 | ||
| ); | ||
| } | ||
|
|
||
| function selectFork24683314() public { | ||
| vm.createSelectFork( | ||
| "https://virtual.mainnet.eu.rpc.tenderly.co/61589e0a-d204-449b-b095-64366ea949cb", | ||
| 24_683_314 | ||
| ); | ||
| } |
There was a problem hiding this comment.
I think we only need a single tenderly virtual testnet for these forks, by passing a different blocknumber to vm.createSelectFork.
4 participants
Contract
Preimage