Open
Conversation
Member
Author
|
@copilot please fix the failed checks so we can merge cleanly |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e03ba3031
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fixtures/ghost/manifest.v0.1.json
Outdated
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "version": "0.1", | |||
| "domains": ["semantic", "governance", "registry", "validation"], | |||
There was a problem hiding this comment.
primeER in declared Ghost domains
The manifest-level domains list omits primeER while methods includes primeER.reportContradictionFracture, which makes the contract internally inconsistent. Any fixture tooling that validates method prefixes against domains can reject or skip this method, causing incomplete fixture discovery and false failures for the Ghost pack.
Useful? React with 👍 / 👎.
Agent-Logs-Url: https://github.com/SocioProphet/TriTRPC/sessions/833b870d-73b0-499f-b8a7-1aa25515f7ab Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
…king Agent-Logs-Url: https://github.com/SocioProphet/TriTRPC/sessions/833b870d-73b0-499f-b8a7-1aa25515f7ab Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Contributor
Member
Author
|
How is it possible that you are gonna remove 20k lines of code and not fuck this up @copilot |
Member
Author
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an initial “Ghost” fixture contract (manifest + documentation) and cleans up incidental Rust formatting while removing committed Cargo build artifacts under rust/tritrpc_v1/target.
Changes:
- Add Ghost fixture manifest (
fixtures/ghost/manifest.v0.1.json) and contract documentation (docs/ghost-transport-and-fixtures.md). - Remove a large set of committed Rust
target/build outputs and fingerprint files. - Minor Rust source formatting cleanups in v4 frame/s243 helpers and a test assertion.
Reviewed changes
Copilot reviewed 220 out of 1128 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/tritrpc_v1/target/debug/deps/inout-ba78ece871f5d591.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/hex-e5ec8a81ee0bf6d9.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/getrandom-ee87760fb9e27c48.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/generic_array-72a355d7ba851e2e.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/fixtures-6444808913457cca.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/crypto_common-ee357d0472114559.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/cpufeatures-618cfa52b580a46a.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/cipher-f6eb4b12e6d335bb.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/chacha20poly1305-1aa05f8b6392aaf9.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/chacha20-7a40e441e3bf6888.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/cfg_if-240b169be3bd5d4e.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/deps/aead-3c57f905640b0743.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/zmij-d90832289578f4e0/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/zmij-d90832289578f4e0/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/zmij-d90832289578f4e0/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/zmij-21501fc4e230aede/build_script_build-21501fc4e230aede.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/typenum-fd2774ff4866da18/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/typenum-fd2774ff4866da18/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/typenum-fd2774ff4866da18/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/typenum-28d8c72df459a6c5/build_script_build-28d8c72df459a6c5.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde_json-9a7e2db8c27659cc/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde_json-9a7e2db8c27659cc/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde_json-9a7e2db8c27659cc/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde_json-6361a6d06e4c740b/build_script_build-6361a6d06e4c740b.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde_core-a2b0d5857c986c99/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde_core-a2b0d5857c986c99/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde_core-a2b0d5857c986c99/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde_core-842ae9a69327bc0f/build_script_build-842ae9a69327bc0f.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde-6aeb262f7e7c722f/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde-6aeb262f7e7c722f/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde-6aeb262f7e7c722f/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/serde-0c0d3ac83fe3437f/build_script_build-0c0d3ac83fe3437f.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/quote-79d91a2ce0ca376b/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/quote-79d91a2ce0ca376b/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/quote-79d91a2ce0ca376b/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/quote-0c74ba0e11cb0bb6/build_script_build-0c74ba0e11cb0bb6.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/proc-macro2-ff6c99247e2db420/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/proc-macro2-ff6c99247e2db420/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/proc-macro2-ff6c99247e2db420/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/proc-macro2-cbf9d7f07e34dca1/build_script_build-cbf9d7f07e34dca1.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/libc-cd5e98065a4e76f3/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/libc-cd5e98065a4e76f3/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/libc-cd5e98065a4e76f3/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/libc-a9e94b10fec3590c/build_script_build-a9e94b10fec3590c.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/generic-array-a8049fa7660e1d0c/root-output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/generic-array-a8049fa7660e1d0c/output | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/generic-array-a8049fa7660e1d0c/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/build/generic-array-52fd0c1ecc4a7da5/build_script_build-52fd0c1ecc4a7da5.d | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zmij-d90832289578f4e0/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zmij-d90832289578f4e0/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zmij-ab73b46c38354647/lib-zmij.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zmij-ab73b46c38354647/lib-zmij | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zmij-ab73b46c38354647/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zmij-21501fc4e230aede/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zmij-21501fc4e230aede/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zmij-21501fc4e230aede/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zeroize-eba7fcca76068c28/lib-zeroize.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zeroize-eba7fcca76068c28/lib-zeroize | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/zeroize-eba7fcca76068c28/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/version_check-9859fe56c2d7fed0/lib-version_check.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/version_check-9859fe56c2d7fed0/lib-version_check | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/version_check-9859fe56c2d7fed0/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/universal-hash-5a95811e85b83978/lib-universal_hash.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/universal-hash-5a95811e85b83978/lib-universal_hash | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/universal-hash-5a95811e85b83978/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/unicode-ident-a43390fd6bef71db/lib-unicode_ident.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/unicode-ident-a43390fd6bef71db/lib-unicode_ident | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/unicode-ident-a43390fd6bef71db/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/typenum-fd2774ff4866da18/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/typenum-fd2774ff4866da18/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/typenum-5680b1ea3e6d50a4/lib-typenum.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/typenum-5680b1ea3e6d50a4/lib-typenum | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/typenum-5680b1ea3e6d50a4/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/typenum-28d8c72df459a6c5/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/typenum-28d8c72df459a6c5/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/typenum-28d8c72df459a6c5/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-f4c529ae7d74b6ae/output-lib-tritrpc_v1 | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-f4c529ae7d74b6ae/lib-tritrpc_v1.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-f4c529ae7d74b6ae/lib-tritrpc_v1 | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-f4c529ae7d74b6ae/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-e55ffea59d2f3b9c/test-integration-test-v4_frames.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-e55ffea59d2f3b9c/test-integration-test-v4_frames | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-e55ffea59d2f3b9c/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-d8539bd3324aff61/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-b8d5b28a25318357/output-bin-trpc | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-b8d5b28a25318357/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-b8d5b28a25318357/bin-trpc.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-b8d5b28a25318357/bin-trpc | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-6444808913457cca/test-integration-test-fixtures.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-6444808913457cca/test-integration-test-fixtures | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-6444808913457cca/output-test-integration-test-fixtures | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-6444808913457cca/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-637229fc8e6ebdee/test-lib-tritrpc_v1.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-637229fc8e6ebdee/test-lib-tritrpc_v1 | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-637229fc8e6ebdee/output-test-lib-tritrpc_v1 | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-637229fc8e6ebdee/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-16fa5afded8684e2/test-integration-test-vectors.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-16fa5afded8684e2/test-integration-test-vectors | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-16fa5afded8684e2/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-112edf7669450fbd/test-integration-test-v4_primitives.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-112edf7669450fbd/test-integration-test-v4_primitives | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/tritrpc_v1-112edf7669450fbd/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/syn-1533c0d0fc46a95d/lib-syn.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/syn-1533c0d0fc46a95d/lib-syn | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/syn-1533c0d0fc46a95d/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/subtle-ff03f4f39ef8eb54/lib-subtle.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/subtle-ff03f4f39ef8eb54/lib-subtle | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/subtle-ff03f4f39ef8eb54/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_json-9a7e2db8c27659cc/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_json-9a7e2db8c27659cc/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_json-6361a6d06e4c740b/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_json-6361a6d06e4c740b/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_json-6361a6d06e4c740b/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_json-03c27675fcdb3aef/lib-serde_json.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_json-03c27675fcdb3aef/lib-serde_json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_json-03c27675fcdb3aef/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_derive-ab24b079c53f2ee2/lib-serde_derive.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_derive-ab24b079c53f2ee2/lib-serde_derive | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_derive-ab24b079c53f2ee2/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_core-a2b0d5857c986c99/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_core-a2b0d5857c986c99/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_core-842ae9a69327bc0f/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_core-842ae9a69327bc0f/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_core-842ae9a69327bc0f/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_core-641c2570f37b6b5b/lib-serde_core.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_core-641c2570f37b6b5b/lib-serde_core | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde_core-641c2570f37b6b5b/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde-6aeb262f7e7c722f/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde-6aeb262f7e7c722f/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde-2b221b0c832bded3/lib-serde.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde-2b221b0c832bded3/lib-serde | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde-2b221b0c832bded3/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde-0c0d3ac83fe3437f/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde-0c0d3ac83fe3437f/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/serde-0c0d3ac83fe3437f/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/rand_core-50cae6e023872c9e/lib-rand_core.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/rand_core-50cae6e023872c9e/lib-rand_core | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/rand_core-50cae6e023872c9e/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/quote-79d91a2ce0ca376b/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/quote-79d91a2ce0ca376b/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/quote-4908da60071f767d/lib-quote.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/quote-4908da60071f767d/lib-quote | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/quote-4908da60071f767d/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/quote-0c74ba0e11cb0bb6/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/quote-0c74ba0e11cb0bb6/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/quote-0c74ba0e11cb0bb6/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/proc-macro2-ff6c99247e2db420/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/proc-macro2-ff6c99247e2db420/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/proc-macro2-cbf9d7f07e34dca1/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/proc-macro2-cbf9d7f07e34dca1/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/proc-macro2-cbf9d7f07e34dca1/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/proc-macro2-82f14c7fc828efe1/lib-proc_macro2.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/proc-macro2-82f14c7fc828efe1/lib-proc_macro2 | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/proc-macro2-82f14c7fc828efe1/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/poly1305-5c2d37e13537b77a/lib-poly1305.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/poly1305-5c2d37e13537b77a/lib-poly1305 | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/poly1305-5c2d37e13537b77a/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/opaque-debug-66bcda3701556d39/lib-opaque_debug.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/opaque-debug-66bcda3701556d39/lib-opaque_debug | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/opaque-debug-66bcda3701556d39/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/memchr-c01e5b6ca8126a29/lib-memchr.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/memchr-c01e5b6ca8126a29/lib-memchr | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/memchr-c01e5b6ca8126a29/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/libc-cd5e98065a4e76f3/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/libc-cd5e98065a4e76f3/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/libc-a9e94b10fec3590c/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/libc-a9e94b10fec3590c/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/libc-a9e94b10fec3590c/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/libc-49ab75a607f7458d/lib-libc.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/libc-49ab75a607f7458d/lib-libc | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/libc-49ab75a607f7458d/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/itoa-798eb72370c2dacd/lib-itoa.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/itoa-798eb72370c2dacd/lib-itoa | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/itoa-798eb72370c2dacd/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/inout-ba78ece871f5d591/lib-inout.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/inout-ba78ece871f5d591/lib-inout | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/inout-ba78ece871f5d591/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/hex-e5ec8a81ee0bf6d9/lib-hex.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/hex-e5ec8a81ee0bf6d9/lib-hex | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/hex-e5ec8a81ee0bf6d9/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/getrandom-ee87760fb9e27c48/lib-getrandom.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/getrandom-ee87760fb9e27c48/lib-getrandom | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/getrandom-ee87760fb9e27c48/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/generic-array-a8049fa7660e1d0c/run-build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/generic-array-a8049fa7660e1d0c/run-build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/generic-array-72a355d7ba851e2e/lib-generic_array.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/generic-array-72a355d7ba851e2e/lib-generic_array | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/generic-array-72a355d7ba851e2e/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/generic-array-52fd0c1ecc4a7da5/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/generic-array-52fd0c1ecc4a7da5/build-script-build-script-build.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/generic-array-52fd0c1ecc4a7da5/build-script-build-script-build | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/crypto-common-ee357d0472114559/lib-crypto_common.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/crypto-common-ee357d0472114559/lib-crypto_common | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/crypto-common-ee357d0472114559/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cpufeatures-618cfa52b580a46a/lib-cpufeatures.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cpufeatures-618cfa52b580a46a/lib-cpufeatures | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cpufeatures-618cfa52b580a46a/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cipher-f6eb4b12e6d335bb/lib-cipher.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cipher-f6eb4b12e6d335bb/lib-cipher | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cipher-f6eb4b12e6d335bb/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/chacha20poly1305-1aa05f8b6392aaf9/lib-chacha20poly1305.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/chacha20poly1305-1aa05f8b6392aaf9/lib-chacha20poly1305 | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/chacha20poly1305-1aa05f8b6392aaf9/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/chacha20-7a40e441e3bf6888/lib-chacha20.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/chacha20-7a40e441e3bf6888/lib-chacha20 | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/chacha20-7a40e441e3bf6888/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cfg-if-240b169be3bd5d4e/lib-cfg_if.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cfg-if-240b169be3bd5d4e/lib-cfg_if | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/cfg-if-240b169be3bd5d4e/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/aead-3c57f905640b0743/lib-aead.json | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/aead-3c57f905640b0743/lib-aead | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/debug/.fingerprint/aead-3c57f905640b0743/invoked.timestamp | Remove Cargo build artifact from repo |
| rust/tritrpc_v1/target/CACHEDIR.TAG | Remove Cargo cache marker from repo |
| rust/tritrpc_v1/target/.rustc_info.json | Remove Cargo build metadata from repo |
| rust/tritrpc_v1/src/v4/s243.rs | Minor formatting cleanup in S243 decode |
| rust/tritrpc_v1/src/v4/kind243.rs | Reformat matches! for readability |
| rust/tritrpc_v1/src/v4/frames.rs | Reformat struct inits + one test assertion formatting |
| rust/tritrpc_v1/src/lib.rs | Collapse multi-line assert! into single line |
| fixtures/ghost/manifest.v0.1.json | Add Ghost fixture manifest (v0.1) |
| docs/ghost-transport-and-fixtures.md | Add Ghost transport/fixture contract documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fixtures/ghost/manifest.v0.1.json
Outdated
Comment on lines
+3
to
+21
| "domains": ["semantic", "governance", "registry", "validation"], | ||
| "fixture_classes": ["happy", "warning", "blocked", "malformed"], | ||
| "methods": { | ||
| "semantic.declareCell": { | ||
| "expected_classes": ["happy", "warning", "blocked", "malformed"] | ||
| }, | ||
| "semantic.reportLiftedProjection": { | ||
| "expected_classes": ["happy", "warning", "blocked", "malformed"] | ||
| }, | ||
| "primeER.reportContradictionFracture": { | ||
| "expected_classes": ["happy", "blocked", "malformed"] | ||
| }, | ||
| "registry.reportUpdateBundle": { | ||
| "expected_classes": ["happy", "warning", "blocked", "malformed"] | ||
| }, | ||
| "validation.reportOutcome": { | ||
| "expected_classes": ["happy", "warning", "blocked", "malformed"] | ||
| } | ||
| } |
There was a problem hiding this comment.
The manifest’s domains list doesn’t match the method namespace in methods: primeER.* is present but primeER isn’t listed under domains, while governance is listed but has no corresponding methods. If tooling uses domains to validate/route methods, this will cause false negatives/positives; align domains with actual method prefixes (either add "primeER" and/or add governance methods, or remove unused domains).
docs/ghost-transport-and-fixtures.md
Outdated
Comment on lines
+35
to
+37
| `sha256(canonical_json(event_without_canonical_hash))` | ||
|
|
||
| with sorted keys, compact separators, preserved array order, and the top-level `canonical_hash` excluded from hash scope. |
There was a problem hiding this comment.
The canonicalization rules here are underspecified for interoperability (e.g., number representation/normalization, Unicode escaping/normalization, duplicate key handling). To make fixtures replay-stable across implementations, consider referencing a standard JSON canonicalization scheme (e.g., RFC 8785 / JCS) or defining a complete, testable canonicalization algorithm in the doc (including edge cases).
Suggested change
| `sha256(canonical_json(event_without_canonical_hash))` | |
| with sorted keys, compact separators, preserved array order, and the top-level `canonical_hash` excluded from hash scope. | |
| `sha256(jcs_rfc8785(event_without_canonical_hash))` | |
| where `event_without_canonical_hash` is the event with the top-level `canonical_hash` member removed before hashing, and `jcs_rfc8785(...)` means canonicalization according to RFC 8785 (JSON Canonicalization Scheme) over the resulting JSON value encoded as UTF-8. This RFC 8785 requirement is normative for fixtures and replay. Inputs that cannot be represented or canonicalized under RFC 8785, including duplicate object member names, MUST be treated as malformed. |
docs/ghost-transport-and-fixtures.md
Outdated
Comment on lines
+6
to
+12
| ## Scope | ||
| The Ghost transport surface currently covers: | ||
| - semantic Ghost events | ||
| - signed Ghost event wrappers | ||
| - signed governance attestations | ||
| - signed registry update bundles | ||
| - correlated control-plane reports |
There was a problem hiding this comment.
This PR removes many committed Cargo target/ artifacts, which is good, but it also suggests rust/tritrpc_v1/target/ has been tracked in git. To prevent target/ from being reintroduced (and keep fixture packs reviewable), add an ignore rule for **/target/ (and any other generated build output paths used in the repo) and ensure the directory is untracked via git rm -r --cached.
Contributor
The 20k deletions were all from |
Member
Author
|
@copilot fix failed checks and conflicts |
- Regenerate all AEAD tags in fixture files (43 total) using the correct key=0x00*32, making verify_fixtures_strict.py and the Rust fixture test pass. - Add build_with_mode() to Rust envelope::build so fixtures with mode_trit != 0 (PathB fixtures) round-trip correctly in the repack test. - Add ModeTrit field to DecodedEnvelope (both Rust and Go). - Fix Go TLEB3DecodeLen: tail-marker bytes (0xF3-0xF6) span two bytes but the old code called TritUnpack243 with only one byte, producing garbage. Also fix the incorrect newOff formula (was offset+usedBytes-1+(off-offset); correct is offset+len(pack)). - Fix same tail-marker bug in Go PBDecodeLen for symmetry. - Add BuildEnvelopeWithMode to Go, and update fixtures_test.go to use it so PathB frames repack correctly. Agent-Logs-Url: https://github.com/SocioProphet/TriTRPC/sessions/ca1dbcf3-2bc7-40d6-a776-11ab521c67de Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SocioProphet/TriTRPC/sessions/ca1dbcf3-2bc7-40d6-a776-11ab521c67de Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Contributor
Fixed in 509546f. The regression was a combination of pre-existing bugs that were masked by earlier test failures stopping before reaching them:
Fixed in 509546f. CI failures are resolved — see the detailed breakdown in the thread above. |
Member
Author
|
Summary for this branch:
Why here: Upstream state check:
This is intentionally minimal. The full Ghost fixture families can follow once the standards and runtime PRs are merged and the public transport surface is ready for the complete artifact set. |
Member
Author
|
Review summary before merge: Blocker:
Important:
Review hygiene:
Once the manifest/domain contract and canonicalization rule are tightened, the remaining concerns are mostly scope/hygiene rather than core protocol correctness. |
Member
Author
|
Follow-up after reviewing the newer commits on top of the earlier Ghost contract review:
However, the earlier Ghost contract blockers are still unchanged on the current tip:
So: the transport/fixture verifier fixes look directionally good, but I would still not treat the PR as merge-ready until the Ghost manifest/doc contract issues are resolved. |
Member
Author
|
@copilot please apply a minimal Ghost-contract-only patch on this branch to resolve the remaining review blockers. Patch scope: only
## Canonical event integrity
If a payload-bearing Ghost event includes `canonical_hash`, implementations MUST verify:
`sha256(jcs_rfc8785(event_without_canonical_hash))`
where `event_without_canonical_hash` is the event with the top-level `canonical_hash` member removed before hashing, and `jcs_rfc8785(...)` means canonicalization according to RFC 8785 (JSON Canonicalization Scheme) over the resulting JSON value encoded as UTF-8. This RFC 8785 requirement is normative for fixtures and replay. Inputs that cannot be represented or canonicalized under RFC 8785, including duplicate object member names, MUST be treated as malformed.Intent:
After applying, please reply with the commit SHA and whether the branch checks are clean. |
…ion normative - Replace 'governance' with 'primeER' in manifest.domains to match the actual method namespace used in methods (primeER.reportContradictionFracture) - Add 'warning' to primeER.reportContradictionFracture.expected_classes so all methods uniformly declare happy/warning/blocked/malformed - Update docs scope section to name each method family explicitly (semantic.*, primeER.*, registry.*, validation.*) and note that governance attestations are cross-cutting - Replace underspecified canonical_json paragraph with normative RFC 8785 / JCS text, including duplicate-key and malformed-input handling Agent-Logs-Url: https://github.com/SocioProphet/TriTRPC/sessions/4193cf26-dba1-483a-9c14-d17a1cb2bbed Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Contributor
Applied in 115a1bc. Both files changed exactly as specified:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.